Skip to content

Commit 839fa75

Browse files
authored
feat(cubesql): Support Node.js 18 (#5900)
1 parent 28be260 commit 839fa75

File tree

6 files changed

+16
-46
lines changed

6 files changed

+16
-46
lines changed

.github/workflows/publish.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
name: Build native Linux ${{ matrix.node-version }} ${{ matrix.target }}
7575
strategy:
7676
matrix:
77-
node-version: [14, 16, 17]
77+
node-version: 14
7878
target: ["x86_64-unknown-linux-gnu", "aarch64-unknown-linux-gnu"]
7979
include:
8080
- target: aarch64-unknown-linux-gnu
@@ -84,7 +84,7 @@ jobs:
8484
package_target_libc: glibc
8585
fail-fast: false
8686
container:
87-
image: cubejs/rust-cross:${{ matrix.target }}-10052021
87+
image: cubejs/rust-cross:${{ matrix.target }}-02012023
8888

8989
steps:
9090
- name: Checkout
@@ -153,7 +153,7 @@ jobs:
153153
name: Build ${{ matrix.os-version }} ${{ matrix.node-version }}
154154
strategy:
155155
matrix:
156-
node-version: [14.x, 16.x, 17.x]
156+
node-version: 14.x
157157
os-version: [windows-2019, macos-11]
158158
fail-fast: false
159159

.github/workflows/push.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343

4444
strategy:
4545
matrix:
46-
node-version: [14.x, 16.x]
46+
node-version: [14.x, 16.x, 18.x]
4747
fail-fast: false
4848

4949
steps:

.github/workflows/rust-cubesql.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,11 @@ jobs:
126126
name: Build Linux GNU ${{ matrix.node-version }}.x ${{ matrix.target }}
127127
strategy:
128128
matrix:
129-
node-version: [12, 14, 16, 17]
129+
node-version: [14, 16, 18]
130130
target: ["x86_64-unknown-linux-gnu", "aarch64-unknown-linux-gnu"]
131131
fail-fast: false
132132
container:
133-
image: cubejs/rust-cross:${{ matrix.target }}-10052021
133+
image: cubejs/rust-cross:${{ matrix.target }}-02012023
134134

135135
steps:
136136
- name: Checkout
@@ -202,7 +202,8 @@ jobs:
202202

203203
strategy:
204204
matrix:
205-
node-version: [12.x, 14.x, 16.x, 17.x]
205+
# We dont need to test under all versions, we do it under linux
206+
node-version: [14.x]
206207
os-version: [windows-2019, macos-11]
207208
fail-fast: false
208209

packages/cubejs-backend-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"module_name": "index",
4646
"host": "https://github.com/cube-js/cube.js/releases/download/",
4747
"remote_path": "v{version}",
48-
"package_name": "native-{node_abi}-{platform}-{arch}-{libc}.tar.gz",
48+
"package_name": "native-{platform}-{arch}-{libc}.tar.gz",
4949
"module_path": "native",
5050
"pkg_path": "."
5151
},

packages/cubejs-testing/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
"driver:databricks:snap": "jest --verbose --updateSnapshot -i dist/test/driver-databricks.test.js",
4949
"integration:cubestore": "jest --verbose --updateSnapshot -i dist/test/driver-cubestore.test.js",
5050
"rest:postgres": "yarn tsc && clear && jest --verbose -i dist/test/rest-postgres.test.js",
51-
"smoke": "jest --verbose -i 'dist/test/smoke-(?!.*?(redshift|bigquery|firebolt))'",
51+
"smoke": "jest --verbose -i 'dist/test/smoke-(?!.*?(redshift|bigquery|firebolt|cubesql))'",
5252
"smoke:athena": "jest --verbose -i dist/test/smoke-athena.test.js",
5353
"smoke:athena:snapshot": "jest --verbose --updateSnapshot -i dist/test/smoke-athena.test.js",
5454
"smoke:bigquery": "jest --verbose -i dist/test/smoke-bigquery.test.js",

yarn.lock

Lines changed: 6 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -6616,31 +6616,11 @@
66166616
"@types/node" "*"
66176617
form-data "^3.0.0"
66186618

6619-
"@types/node@*", "@types/node@>=12.12.47", "@types/node@^12", "@types/node@^12.12.17":
6619+
"@types/node@*", "@types/node@12.12.50", "@types/node@>=12.12.47", "@types/node@>=13.7.0", "@types/node@^10.17.55", "@types/node@^10.17.60", "@types/node@^12", "@types/node@^12.12.17", "@types/node@^14.14.35":
66206620
version "12.20.41"
66216621
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.20.41.tgz#81d7734c5257da9f04354bd9084a6ebbdd5198a5"
66226622
integrity sha512-f6xOqucbDirG7LOzedpvzjP3UTmHttRou3Mosx3vL9wr9AIQGhcPgVnqa8ihpZYnxyM1rxeNCvTyukPKZtq10Q==
66236623

6624-
6625-
version "12.12.50"
6626-
resolved "https://registry.yarnpkg.com/@types/node/-/node-12.12.50.tgz#e9b2e85fafc15f2a8aa8fdd41091b983da5fd6ee"
6627-
integrity sha512-5ImO01Fb8YsEOYpV+aeyGYztcYcjGsBvN4D7G5r1ef2cuQOpymjWNQi5V0rKHE6PC2ru3HkoUr/Br2/8GUA84w==
6628-
6629-
"@types/node@>=13.7.0":
6630-
version "18.11.11"
6631-
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.11.tgz#1d455ac0211549a8409d3cdb371cd55cc971e8dc"
6632-
integrity sha512-KJ021B1nlQUBLopzZmPBVuGU9un7WJd/W4ya7Ih02B4Uwky5Nja0yGYav2EfYIk0RR2Q9oVhf60S2XR1BCWJ2g==
6633-
6634-
"@types/node@^10.17.55", "@types/node@^10.17.60":
6635-
version "10.17.60"
6636-
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.60.tgz#35f3d6213daed95da7f0f73e75bcc6980e90597b"
6637-
integrity sha512-F0KIgDJfy2nA3zMLmWGKxcH2ZVEtCZXHHdOQs2gSaQ27+lNeEfGxzkIw90aXswATX7AZ33tahPbzy6KAfUreVw==
6638-
6639-
"@types/node@^14.14.35":
6640-
version "14.18.34"
6641-
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.34.tgz#cd2e6fa0dbfb08a62582a7b967558e73c32061ec"
6642-
integrity sha512-hcU9AIQVHmPnmjRK+XUUYlILlr9pQrsqSrwov/JK1pnf3GTQowVBhx54FbvM0AU/VXGH4i3+vgXS5EguR7fysA==
6643-
66446624
"@types/normalize-package-data@^2.4.0":
66456625
version "2.4.1"
66466626
resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.1.tgz#d3357479a0fdfdd5907fe67e17e0a85c906e1301"
@@ -6688,7 +6668,7 @@
66886668
resolved "https://registry.yarnpkg.com/@types/qs/-/qs-6.9.7.tgz#63bb7d067db107cc1e457c303bc25d511febf6cb"
66896669
integrity sha512-FGa1F62FT09qcrueBA6qYTrJPVDzah9a+493+o2PCXsesWHIn27G98TsSMs3WPNbZIEj4+VJf6saSFpvD+3Zsw==
66906670

6691-
"@types/ramda@^0.27.32", "@types/ramda@^0.27.34", "@types/ramda@^0.27.40":
6671+
"@types/ramda@0.27.40", "@types/ramda@^0.27.32", "@types/ramda@^0.27.34", "@types/ramda@^0.27.40":
66926672
version "0.27.40"
66936673
resolved "https://registry.yarnpkg.com/@types/ramda/-/ramda-0.27.40.tgz#99f307356fe553095ee4d3c2af2b0eb3af7a8413"
66946674
integrity sha512-V99ZfTH2tqVYdLDAlgh2uT+N074HPgqnAsMjALKSBqogYd0HbuuGMqNukJ6fk9Ml/Htaus76fsc4Yh3p7q1VdQ==
@@ -11764,9 +11744,9 @@ de-indent@^1.0.2:
1176411744
integrity sha1-sgOOhG3DO6pXlhKNCAS0VbjB4h0=
1176511745

1176611746
deasync@^0.1.15:
11767-
version "0.1.24"
11768-
resolved "https://registry.yarnpkg.com/deasync/-/deasync-0.1.24.tgz#6ecc9c6ff9eba64a4f4572ae3c4db77fed09268a"
11769-
integrity sha512-i98vg42xNfRZCymummMAN0rIcQ1gZFinSe3btvPIvy6JFTaeHcumeKybRo2HTv86nasfmT0nEgAn2ggLZhOCVA==
11747+
version "0.1.28"
11748+
resolved "https://registry.yarnpkg.com/deasync/-/deasync-0.1.28.tgz#9b447b79b3f822432f0ab6a8614c0062808b5ad2"
11749+
integrity sha512-QqLF6inIDwiATrfROIyQtwOQxjZuek13WRYZ7donU5wJPLoP67MnYxA6QtqdvdBy2mMqv5m3UefBVdJjvevOYg==
1177011750
dependencies:
1177111751
bindings "^1.5.0"
1177211752
node-addon-api "^1.7.1"
@@ -23435,7 +23415,7 @@ rc-tree-select@~4.3.0:
2343523415
rc-tree "^4.0.0"
2343623416
rc-util "^5.0.5"
2343723417

23438-
rc-tree@^4.0.0:
23418+
rc-tree@4.1.5, rc-tree@^4.0.0, rc-tree@~4.2.1:
2343923419
version "4.1.5"
2344023420
resolved "https://registry.yarnpkg.com/rc-tree/-/rc-tree-4.1.5.tgz#734ab1bfe835e78791be41442ca0e571147ab6fa"
2344123421
integrity sha512-q2vjcmnBDylGZ9/ZW4F9oZMKMJdbFWC7um+DAQhZG1nqyg1iwoowbBggUDUaUOEryJP+08bpliEAYnzJXbI5xQ==
@@ -23446,17 +23426,6 @@ rc-tree@^4.0.0:
2344623426
rc-util "^5.0.0"
2344723427
rc-virtual-list "^3.0.1"
2344823428

23449-
rc-tree@~4.2.1:
23450-
version "4.2.2"
23451-
resolved "https://registry.yarnpkg.com/rc-tree/-/rc-tree-4.2.2.tgz#4429187cbbfbecbe989714a607e3de8b3ab7763f"
23452-
integrity sha512-V1hkJt092VrOVjNyfj5IYbZKRMHxWihZarvA5hPL/eqm7o2+0SNkeidFYm7LVVBrAKBpOpa0l8xt04uiqOd+6w==
23453-
dependencies:
23454-
"@babel/runtime" "^7.10.1"
23455-
classnames "2.x"
23456-
rc-motion "^2.0.1"
23457-
rc-util "^5.0.0"
23458-
rc-virtual-list "^3.0.1"
23459-
2346023429
rc-trigger@^5.0.0, rc-trigger@^5.0.4, rc-trigger@^5.1.2, rc-trigger@^5.2.10:
2346123430
version "5.2.10"
2346223431
resolved "https://registry.yarnpkg.com/rc-trigger/-/rc-trigger-5.2.10.tgz#8a0057a940b1b9027eaa33beec8a6ecd85cce2b1"

0 commit comments

Comments
 (0)