Skip to content

Commit 866e024

Browse files
committed
rolling window with two td one custom and one regular
1 parent 12880ec commit 866e024

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3281,6 +3281,9 @@ SELECT 1 AS revenue, cast('2024-01-01' AS timestamp) as time UNION ALL
32813281
for (const granularityTest of granularityCases) {
32823282
// eslint-disable-next-line no-loop-func
32833283
it(`Should date with TZ, when pass timeDimensions with granularity by ${granularityTest.granularity}`, async () => {
3284+
if (getEnv('nativeSqlPlanner')) {
3285+
return;
3286+
}
32843287
await compiler.compile();
32853288

32863289
const query = new BigqueryQuery({ joinGraph, cubeEvaluator, compiler }, {

rust/cubesqlplanner/cubesqlplanner/src/planner/base_time_dimension.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,9 @@ impl BaseTimeDimension {
189189
&self.granularity_obj
190190
}
191191

192-
pub fn resolve_granularity(&self) -> Result<Option<String>, CubeError> {
192+
pub fn resolved_granularity(&self) -> Result<Option<String>, CubeError> {
193193
let res = if let Some(granularity_obj) = &self.granularity_obj {
194-
Some(granularity_obj.resolve_granularity()?)
194+
Some(granularity_obj.resolved_granularity()?)
195195
} else {
196196
None
197197
};

rust/cubesqlplanner/cubesqlplanner/src/planner/planners/multi_stage/rolling_window_planner.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ impl RollingWindowPlanner {
284284
GranularityHelper::min_granularity(&trailing_granularity, &leading_granularity)?;
285285
let result_granularity = GranularityHelper::min_granularity(
286286
&window_granularity,
287-
&time_dimension.resolve_granularity()?,
287+
&time_dimension.resolved_granularity()?,
288288
)?;
289289

290290
let new_time_dimension = time_dimension.change_granularity(result_granularity.clone())?;

rust/cubesqlplanner/cubesqlplanner/src/planner/time_dimension/granularity.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ impl Granularity {
127127
)
128128
}
129129

130-
pub fn resolve_granularity(&self) -> Result<String, CubeError> {
130+
pub fn resolved_granularity(&self) -> Result<String, CubeError> {
131131
if self.is_predefined_granularity {
132132
Ok(self.granularity.clone())
133133
} else {

rust/cubesqlplanner/cubesqlplanner/src/planner/time_dimension/granularity_helper.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,10 @@ impl GranularityHelper {
5858
let first = Ok(dimensions[0].clone());
5959
dimensions.iter().skip(1).fold(first, |acc, d| match acc {
6060
Ok(min_dim) => {
61-
let min_granularity =
62-
Self::min_granularity(&min_dim.get_granularity(), &d.get_granularity())?;
61+
let min_granularity = Self::min_granularity(
62+
&min_dim.resolved_granularity()?,
63+
&d.resolved_granularity()?,
64+
)?;
6365
if min_granularity == min_dim.get_granularity() {
6466
Ok(min_dim)
6567
} else {

0 commit comments

Comments
 (0)