refactor(cubesql): Extract MEASURE UDAF name to const

Author: mcheshkov

rust/cubesql/cubesql/src/compile/engine/udf/common.rs

@@ -2259,6 +2259,8 @@ pub fn create_pg_get_constraintdef_udf() -> ScalarUDF {
     )
 }
 
+pub const MEASURE_UDAF_NAME: &str = "measure";
+
 pub fn create_measure_udaf() -> AggregateUDF {
     let signature = Signature::any(1, Volatility::Immutable);
 
@@ -2279,7 +2281,7 @@ pub fn create_measure_udaf() -> AggregateUDF {
     let state_type: StateTypeFunction = Arc::new(move |_| Ok(state_type.clone()));
 
     AggregateUDF::new(
-        "measure",
+        MEASURE_UDAF_NAME,
         &signature,
         &return_type,
         &accumulator,

rust/cubesql/cubesql/src/compile/rewrite/analysis.rs

@@ -1,5 +1,6 @@
 use crate::{
     compile::{
+        engine::udf::MEASURE_UDAF_NAME,
         rewrite::{
             converter::{is_expr_node, node_to_expr, LogicalPlanToLanguageConverter},
             expr_column_name,
@@ -389,7 +390,7 @@ impl LogicalPlanAnalysis {
                 Some(trivial)
             }
             LogicalPlanLanguage::AggregateUDFExprFun(AggregateUDFExprFun(fun)) => {
-                if fun.to_lowercase() == "measure" {
+                if fun.to_lowercase() == MEASURE_UDAF_NAME {
                     Some(0)
                 } else {
                     None