fix(cubesql): Support to_timestamp(epoch) pg function, fix #8901

Author: droidraja

rust/cubesql/cubesql/src/compile/rewrite/rules/filters.rs

@@ -39,7 +39,7 @@ use chrono::{
 use cubeclient::models::V1CubeMeta;
 use datafusion::{
     arrow::{
-        array::{Date32Array, Date64Array, TimestampNanosecondArray},
+        array::{Date32Array, Date64Array, TimestampNanosecondArray, TimestampSecondArray},
         datatypes::{DataType, IntervalDayTimeType},
     },
     logical_plan::{Column, Expr, Operator},
@@ -2804,6 +2804,7 @@ impl FilterRules {
                                             vec![Decimal::new(*value).to_string(*scale)]
                                         }
                                         ScalarValue::TimestampNanosecond(_, _)
+                                        | ScalarValue::TimestampSecond(_, _)
                                         | ScalarValue::Date32(_)
                                         | ScalarValue::Date64(_) => {
                                             if let Some(timestamp) =
@@ -3561,6 +3562,7 @@ impl FilterRules {
                 Decimal::new(*value).to_string(*scale)
             }
             ScalarValue::TimestampNanosecond(_, _)
+            | ScalarValue::TimestampSecond(_, _)
             | ScalarValue::Date32(_)
             | ScalarValue::Date64(_) => {
                 if let Some(timestamp) = Self::scalar_to_native_datetime(literal) {
@@ -3576,13 +3578,16 @@ impl FilterRules {
     fn scalar_to_native_datetime(literal: &ScalarValue) -> Option<NaiveDateTime> {
         match literal {
             ScalarValue::TimestampNanosecond(_, _)
+            | ScalarValue::TimestampSecond(_, _)
             | ScalarValue::Date32(_)
             | ScalarValue::Date64(_) => {
                 let array = literal.to_array();
                 let timestamp = if let Some(array) =
                     array.as_any().downcast_ref::<TimestampNanosecondArray>()
                 {
                     array.value_as_datetime(0)
+                } else if let Some(array) = array.as_any().downcast_ref::<TimestampSecondArray>() {
+                    array.value_as_datetime(0)
                 } else if let Some(array) = array.as_any().downcast_ref::<Date32Array>() {
                     array.value_as_datetime(0)
                 } else if let Some(array) = array.as_any().downcast_ref::<Date64Array>() {

rust/cubesql/cubesql/src/sql/statement.rs

@@ -940,11 +940,36 @@ impl ToTimestampReplacer {
 }
 
 impl<'ast> Visitor<'ast, ConnectionError> for ToTimestampReplacer {
-    fn visit_identifier(&mut self, identifier: &mut Ident) -> Result<(), ConnectionError> {
-        if identifier.value.to_lowercase() == "to_timestamp" {
-            identifier.value = "str_to_date".to_string()
-        };
+    fn visit_function(&mut self, fun: &mut Function) -> Result<(), ConnectionError> {
+        if fun.name.to_string().to_lowercase() == "to_timestamp" {
+            if fun.args.len() == 1
+                && matches!(
+                    &fun.args[0],
+                    FunctionArg::Unnamed(FunctionArgExpr::Expr(Expr::Value(Value::Number(_, _))))
+                )
+            {
+                fun.name = ObjectName(vec![Ident {
+                    value: "to_timestamp_seconds".to_string(),
+                    quote_style: None,
+                }]);
+            } else {
+                fun.name = ObjectName(vec![Ident {
+                    value: "str_to_date".to_string(),
+                    quote_style: None,
+                }]);
+            }
+        }
 
+        // Continue visiting function arguments
+        self.visit_function_args(&mut fun.args)?;
+        if let Some(over) = &mut fun.over {
+            for res in over.partition_by.iter_mut() {
+                self.visit_expr(res)?;
+            }
+            for order_expr in over.order_by.iter_mut() {
+                self.visit_expr(&mut order_expr.expr)?;
+            }
+        }
         Ok(())
     }
 }