add safeguard

Author: KSDaemon

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -474,14 +474,18 @@ export class BaseQuery {
         return true;
       };
 
-      while (newJoin?.joins.length > 0 && !isJoinTreesEqual(prevJoins, newJoin)) {
+      // Safeguard against infinite loop in case of cyclic joins somehow managed to slip through
+      let cnt = 0;
+
+      while (newJoin?.joins.length > 0 && !isJoinTreesEqual(prevJoins, newJoin) && cnt < 10000) {
         prevJoins = newJoin;
         joinMembersJoinHints = this.collectJoinHintsFromMembers(this.joinMembersFromJoin(newJoin));
         if (!isOrderPreserved(prevJoinMembersJoinHints, joinMembersJoinHints)) {
           throw new UserError(`Can not construct joins for the query, potential loop detected: ${prevJoinMembersJoinHints.join('->')} vs ${joinMembersJoinHints.join('->')}`);
         }
         newJoin = this.joinGraph.buildJoin(constructJH());
         prevJoinMembersJoinHints = joinMembersJoinHints;
+        cnt++;
       }
 
       this.collectedJoinHints = R.uniq(constructJH());