fix(cubesql): Drop ordering from CubeScan during CrossJoin rewrite

CROSS JOIN does not guarantee same ordering as inputs

Author: mcheshkov

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

@@ -2567,19 +2567,13 @@ impl MemberRules {
         left_alias_to_cube_var: &'static str,
         right_alias_to_cube_var: &'static str,
         joined_alias_to_cube_var: &'static str,
-        left_order_var: &'static str,
-        right_order_var: &'static str,
-        new_order_var: &'static str,
         left_ungrouped_var: &'static str,
         right_ungrouped_var: &'static str,
         new_ungrouped_var: &'static str,
     ) -> impl Fn(&mut CubeEGraph, &mut Subst) -> bool {
         let left_alias_to_cube_var = var!(left_alias_to_cube_var);
         let right_alias_to_cube_var = var!(right_alias_to_cube_var);
         let joined_alias_to_cube_var = var!(joined_alias_to_cube_var);
-        let left_order_var = var!(left_order_var);
-        let right_order_var = var!(right_order_var);
-        let new_order_var = var!(new_order_var);
         let left_ungrouped_var = var!(left_ungrouped_var);
         let right_ungrouped_var = var!(right_ungrouped_var);
         let new_ungrouped_var = var!(new_ungrouped_var);
@@ -2601,16 +2595,6 @@ impl MemberRules {
                 for right_alias_to_cube in
                     var_iter!(egraph[subst[right_alias_to_cube_var]], CubeScanAliasToCube).cloned()
                 {
-                    let is_left_order_empty =
-                        Some(true) == egraph[subst[left_order_var]].data.is_empty_list;
-
-                    let is_right_order_empty =
-                        Some(true) == egraph[subst[right_order_var]].data.is_empty_list;
-
-                    if !is_left_order_empty && !is_right_order_empty {
-                        continue;
-                    }
-
                     subst.insert(
                         joined_alias_to_cube_var,
                         egraph.add(LogicalPlanLanguage::CubeScanAliasToCube(
@@ -2623,14 +2607,6 @@ impl MemberRules {
                         )),
                     );
 
-                    let orders = if is_left_order_empty {
-                        subst[right_order_var]
-                    } else {
-                        subst[left_order_var]
-                    };
-
-                    subst.insert(new_order_var, orders);
-
                     let joined_ungrouped = egraph.add(LogicalPlanLanguage::CubeScanUngrouped(
                         CubeScanUngrouped(left_ungrouped && right_ungrouped),
                     ));
@@ -2708,7 +2684,7 @@ impl MemberRules {
                 "?joined_alias_to_cube",
                 cube_scan_members(left_members, right_members),
                 cube_scan_filters("?left_filters", "?right_filters"),
-                "?new_order",
+                cube_scan_order_empty_tail(),
                 "CubeScanLimit:None",
                 "CubeScanOffset:None",
                 "CubeScanSplit:false",
@@ -2720,9 +2696,6 @@ impl MemberRules {
                 "?left_alias_to_cube",
                 "?right_alias_to_cube",
                 "?joined_alias_to_cube",
-                "?left_order",
-                "?right_order",
-                "?new_order",
                 "?left_ungrouped",
                 "?right_ungrouped",
                 "?new_ungrouped",

rust/cubesql/cubesql/src/compile/test/test_cube_join.rs

@@ -246,10 +246,7 @@ async fn test_join_two_subqueries_with_filter_order_limit() {
             measures: Some(vec!["KibanaSampleDataEcommerce.count".to_string(),]),
             dimensions: Some(vec!["Logs.read".to_string(),]),
             segments: Some(vec![]),
-            order: Some(vec![vec![
-                "KibanaSampleDataEcommerce.customer_gender".to_string(),
-                "asc".to_string(),
-            ]]),
+            order: Some(vec![]),
             filters: Some(vec![
                 V1LoadRequestQueryFilterItem {
                     member: Some("KibanaSampleDataEcommerce.customer_gender".to_string()),
@@ -301,10 +298,7 @@ async fn test_join_three_subqueries_with_filter_order_limit_and_split() {
                 granularity: Some("month".to_owned()),
                 date_range: None
             }]),
-            order: Some(vec![vec![
-                "KibanaSampleDataEcommerce.customer_gender".to_string(),
-                "asc".to_string(),
-            ]]),
+            order: Some(vec![]),
             filters: Some(vec![
                 V1LoadRequestQueryFilterItem {
                     member: Some("KibanaSampleDataEcommerce.customer_gender".to_string()),
@@ -350,10 +344,7 @@ async fn test_join_subquery_and_table_with_filter_order_limit() {
             measures: Some(vec!["KibanaSampleDataEcommerce.count".to_string(),]),
             dimensions: Some(vec!["Logs.read".to_string(),]),
             segments: Some(vec![]),
-            order: Some(vec![vec![
-                "KibanaSampleDataEcommerce.customer_gender".to_string(),
-                "asc".to_string(),
-            ]]),
+            order: Some(vec![]),
             filters: Some(vec![
                 V1LoadRequestQueryFilterItem {
                     member: Some("KibanaSampleDataEcommerce.customer_gender".to_string()),
@@ -405,10 +396,7 @@ async fn test_join_two_subqueries_and_table_with_filter_order_limit_and_split()
                 granularity: Some("month".to_owned()),
                 date_range: None
             }]),
-            order: Some(vec![vec![
-                "KibanaSampleDataEcommerce.customer_gender".to_string(),
-                "asc".to_string(),
-            ]]),
+            order: Some(vec![]),
             filters: Some(vec![
                 V1LoadRequestQueryFilterItem {
                     member: Some("KibanaSampleDataEcommerce.customer_gender".to_string()),