fix(firebolt-driver): Automatically cast boolean parameters (#6531)

Author: Jeseeq

packages/cubejs-firebolt-driver/src/FireboltQuery.ts

@@ -1,4 +1,4 @@
-import { BaseQuery, ParamAllocator } from '@cubejs-backend/schema-compiler';
+import { BaseFilter, BaseQuery, ParamAllocator } from '@cubejs-backend/schema-compiler';
 
 const GRANULARITY_TO_INTERVAL: Record<string, string> = {
   day: 'DAY',
@@ -11,6 +11,16 @@ const GRANULARITY_TO_INTERVAL: Record<string, string> = {
   year: 'YEAR'
 };
 
+class FireboltFilter extends BaseFilter {
+  public castParameter() {
+    if (this.definition().type === 'boolean') {
+      return 'CAST(? AS BOOLEAN)';
+    }
+
+    return '?';
+  }
+}
+
 export class FireboltQuery extends BaseQuery {
   public paramAllocator!: ParamAllocator;
 
@@ -25,4 +35,8 @@ export class FireboltQuery extends BaseQuery {
   public timeGroupedColumn(granularity: string, dimension: string) {
     return `DATE_TRUNC('${GRANULARITY_TO_INTERVAL[granularity]}', ${dimension})`;
   }
+
+  public newFilter(filter: any) {
+    return new FireboltFilter(this, filter);
+  }
 }

packages/cubejs-firebolt-driver/test/FireboltQuery.test.ts

@@ -25,7 +25,11 @@ cube(\`sales\`, {
     salesDatetime: {
       type: 'time',
       sql: 'sales_datetime'
-    }
+    },
+    isShiped: {
+      type: 'boolean',
+      sql: 'is_shiped',
+    },
   }
 });
 `,
@@ -58,4 +62,28 @@ cube(\`sales\`, {
       'DATE_TRUNC(\'DAY\', "sales".sales_datetime)'
     );
   }));
-});
+
+  it('should cast BOOLEAN', () => compiler.compile().then(() => {
+    const query = new FireboltQuery(
+      { joinGraph, cubeEvaluator, compiler },
+      {
+        measures: ['sales.count'],
+        filters: [
+          {
+            member: "sales.isShiped",
+            operator: "equals",
+            values: ["true"]
+          }
+        ]
+      }
+    )
+
+    const queryAndParams = query.buildSqlAndParams();
+
+    expect(queryAndParams[0]).toContain(
+      '("sales".is_shiped = CAST(? AS BOOL))'
+    );
+
+    expect(queryAndParams[1]).toEqual(["true"]);
+  }))
+})