chore: use CUBEJS_DB_NAME for Athena default database

Author: paulorsbrito

docs/content/Configuration/Databases/AWS-Athena.mdx

@@ -32,12 +32,10 @@ CUBEJS_AWS_ATHENA_CATALOG=AwsDataCatalog
 | ------------------------------- | ---------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------ | :------: | :----------------------------------------------------------------------: |
 | `CUBEJS_AWS_KEY`                | The AWS Access Key ID to use for database connections                                                                  | A valid AWS Access Key ID                        |    ✅    |                                    ✅                                    |
 | `CUBEJS_AWS_SECRET`             | The AWS Secret Access Key to use for database connections                                                              | A valid AWS Secret Access Key                    |    ✅    |                                    ✅                                    |
-| `CUBEJS_AWS_SESSION_TOKEN`      | The AWS Session token if using MFA                                                                                     | A valid AWS Session token                        |    ❌    |                                    ✅                                    |
 | `CUBEJS_AWS_REGION`             | The AWS region of the Cube deployment                                                                                  | [A valid AWS region][aws-docs-regions]           |    ✅    |                                    ✅                                    |
 | `CUBEJS_AWS_S3_OUTPUT_LOCATION` | The S3 path to store query results made by the Cube deployment                                                         | A valid S3 path                                  |    ❌    |                                    ✅                                    |
 | `CUBEJS_AWS_ATHENA_WORKGROUP`   | The name of the workgroup in which the query is being started                                                          | [A valid Athena Workgroup][aws-athena-workgroup] |    ❌    |                                    ✅                                    |
 | `CUBEJS_AWS_ATHENA_CATALOG`     | The name of the catalog to use by default                                                                              | [A valid Athena Catalog name][awsdatacatalog]    |    ❌    |                                    ✅                                    |
-| `CUBEJS_AWS_ATHENA_DATABASE`    | The name of the database to use by default                                                                             | A valid Athena Database name                     |    ❌    |                                    ✅                                    |
 | `CUBEJS_DB_SCHEMA`              | The name of the schema to use as `information_schema` filter. Reduces count of tables loaded during schema generation. | A valid schema name                              |    ❌    |                                    ✅                                    |
 | `CUBEJS_CONCURRENCY`            | The number of concurrent connections each queue has to the database. Default is `5`                                    | A valid number                                   |    ❌    |                                    ❌                                    |
 

packages/cubejs-athena-driver/src/AthenaDriver.ts

@@ -135,7 +135,7 @@ export class AthenaDriver extends BaseDriver implements DriverInterface {
         getEnv('athenaAwsCatalog', { dataSource }),
       database:
         config.database ||
-        getEnv('athenaAwsDatabase', { dataSource }),
+        getEnv('dbName', { dataSource }),
       exportBucket:
         config.exportBucket ||
         getEnv('dbExportBucket', { dataSource }),

packages/cubejs-backend-shared/src/env.ts

@@ -914,20 +914,6 @@ const variables: Record<string, (...args: any) => any> = {
     ]
   ),
 
-  /**
-   * Athena AWS Database.
-   */
-  athenaAwsDatabase: ({
-    dataSource
-  }: {
-    dataSource: string,
-  }) => (
-    // TODO (buntarb): Deprecate and replace?
-    process.env[
-      keyByDataSource('CUBEJS_AWS_ATHENA_DATABASE', dataSource)
-    ]
-  ),
-
   /** ****************************************************************
    * BigQuery Driver                                                 *
    ***************************************************************** */