fix(postgres-driver): release method should not throw (#5395)

Author: buntarb

packages/cubejs-postgres-driver/src/PostgresDriver.ts

@@ -66,6 +66,8 @@ export class PostgresDriver<Config extends PostgresDriverConfiguration = Postgre
     return 2;
   }
 
+  private enabled: boolean = false;
+
   protected readonly pool: Pool;
 
   protected readonly config: Partial<Config>;
@@ -107,13 +109,15 @@ export class PostgresDriver<Config extends PostgresDriverConfiguration = Postgre
       executionTimeout: getEnv('dbQueryTimeout', { dataSource }),
       ...config,
     };
+    this.enabled = true;
   }
 
   /**
    * The easiest way how to add additional configuration from env variables, because
    * you cannot call method in RedshiftDriver.constructor before super.
    */
   protected getInitialConfiguration(
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     dataSource: string,
   ): Partial<PostgresDriverConfiguration> {
     return {
@@ -334,8 +338,11 @@ export class PostgresDriver<Config extends PostgresDriverConfiguration = Postgre
     }
   }
 
-  public release() {
-    return this.pool.end();
+  public async release() {
+    if (this.enabled) {
+      this.pool.end();
+      this.enabled = false;
+    }
   }
 
   public param(paramIndex: number) {

packages/cubejs-postgres-driver/test/PostgresDriver.test.ts

@@ -1,7 +1,5 @@
 import { PostgresDBRunner } from '@cubejs-backend/testing-shared';
-
 import { StartedTestContainer } from 'testcontainers';
-
 import { PostgresDriver } from '../src';
 
 const streamToArray = require('stream-to-array');
@@ -25,11 +23,7 @@ describe('PostgresDriver', () => {
   });
 
   afterAll(async () => {
-    await driver.release();
-
-    if (container) {
-      await container.stop();
-    }
+    await container.stop();
   });
 
   test('type coercion', async () => {
@@ -121,4 +115,19 @@ describe('PostgresDriver', () => {
       );
     }
   });
+
+  // Note: This test MUST be the last in the list.
+  test('release', async () => {
+    expect(async () => {
+      await driver.release();
+    }).not.toThrowError(
+      /Called end on pool more than once/
+    );
+
+    expect(async () => {
+      await driver.release();
+    }).not.toThrowError(
+      /Called end on pool more than once/
+    );
+  });
 });