Skip to content

Commit 98287d6

Browse files
committed
[FIXUP] TODO about timed out queries
1 parent a2c18f0 commit 98287d6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/cubejs-clickhouse-driver/src/ClickHouseDriver.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ export class ClickHouseDriver extends BaseDriver implements DriverInterface {
179179
const promise = (async () => {
180180
await this.client.ping();
181181
signal.throwIfAborted();
182+
// Queries sent by `fn` can hit a timeout error, would _not_ get killed, and continue running in ClickHouse
183+
// TODO should we kill those as well?
182184
const result = await fn(this.client, queryId, signal);
183185
signal.throwIfAborted();
184186
return result;

0 commit comments

Comments
 (0)