fix(schema-compiler): Fix view transpilation for worker_threads and native flows

Author: KSDaemon

packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.ts

@@ -73,7 +73,8 @@ export type DataSchemaCompilerOptions = {
   nativeInstance: NativeInstance;
   cubeFactory: Function;
   cubeDictionary: CubeDictionary;
-  cubeSymbols: CubeSymbols;
+  cubeOnlySymbols: CubeSymbols;
+  cubeAndViewSymbols: CubeSymbols;
   cubeCompilers?: CompilerInterface[];
   contextCompilers?: CompilerInterface[];
   transpilers?: TranspilerInterface[];
@@ -131,7 +132,9 @@ export class DataSchemaCompiler {
 
   private readonly cubeDictionary: CubeDictionary;
 
-  private readonly cubeSymbols: CubeSymbols;
+  private readonly cubeOnlySymbols: CubeSymbols;
+
+  private readonly cubeAndViewSymbols: CubeSymbols;
 
   // Actually should be something like
   // createCube(cubeDefinition: CubeDefinition): CubeDefinitionExtended
@@ -187,7 +190,8 @@ export class DataSchemaCompiler {
     this.cubeNameCompilers = options.cubeNameCompilers || [];
     this.extensions = options.extensions || {};
     this.cubeDictionary = options.cubeDictionary;
-    this.cubeSymbols = options.cubeSymbols;
+    this.cubeOnlySymbols = options.cubeOnlySymbols;
+    this.cubeAndViewSymbols = options.cubeAndViewSymbols;
     this.cubeFactory = options.cubeFactory;
     this.filesToCompile = options.filesToCompile || [];
     this.omitErrors = options.omitErrors || false;
@@ -531,7 +535,8 @@ export class DataSchemaCompiler {
         // Free unneeded resources
         this.compileV8ContextCache = null;
         this.cubeDictionary.free();
-        this.cubeSymbols.free();
+        this.cubeOnlySymbols.free();
+        this.cubeAndViewSymbols.free();
         return res;
       });
     }
@@ -563,14 +568,23 @@ export class DataSchemaCompiler {
     // The structured clone algorithm (@see https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm)
     // which doesn't allow passing any function objects, so we need to sanitize the symbols.
     // Communication with native backend also involves deserialization.
-    const cubeSymbols: Record<string, Record<string, boolean>> = Object.fromEntries(
-      Object.entries(this.cubeSymbols.symbols as Record<string, Record<string, any>>)
+    const cubeOnlySymbols: Record<string, Record<string, boolean>> = Object.fromEntries(
+      Object.entries(this.cubeOnlySymbols.symbols as Record<string, Record<string, any>>)
+        .map(
+          ([key, value]: [string, Record<string, any>]) => [key, Object.fromEntries(
+            Object.keys(value).map((k) => [k, true]),
+          )],
+        ),
+    );
+    const cubeViewSymbols: Record<string, Record<string, boolean>> = Object.fromEntries(
+      Object.entries(this.cubeAndViewSymbols.symbols as Record<string, Record<string, any>>)
         .map(
           ([key, value]: [string, Record<string, any>]) => [key, Object.fromEntries(
             Object.keys(value).map((k) => [k, true]),
           )],
         ),
     );
+    const cubeSymbols = { ...cubeOnlySymbols, ...cubeViewSymbols };
 
     // Transpilers are the same for all files within phase.
     const transpilerNames: string[] = this.transpilers.map(t => t.constructor.name);

packages/cubejs-schema-compiler/src/compiler/PrepareCompiler.ts

@@ -77,7 +77,7 @@ export const prepareCompiler = (repo: SchemaFileRepository, options: PrepareComp
 
   const compilerId = uuidv4();
 
-  const compiler = new DataSchemaCompiler(repo, Object.assign({}, {
+  const compiler = new DataSchemaCompiler(repo, {
     cubeNameCompilers: [cubeDictionary],
     preTranspileCubeCompilers: [cubeSymbols, cubeValidator],
     transpilers,
@@ -91,7 +91,8 @@ export const prepareCompiler = (repo: SchemaFileRepository, options: PrepareComp
     cubeFactory: cubeSymbols.createCube.bind(cubeSymbols),
     compilerCache,
     cubeDictionary,
-    cubeSymbols,
+    cubeOnlySymbols: cubeSymbols,
+    cubeAndViewSymbols: viewCompiler,
     extensions: {
       Funnels,
       RefreshKeys,
@@ -102,7 +103,8 @@ export const prepareCompiler = (repo: SchemaFileRepository, options: PrepareComp
     nativeInstance,
     yamlCompiler,
     compilerId,
-  }, options));
+    ...options
+  });
 
   return {
     compiler,