Skip to content

Commit 9c1fafb

Browse files
committed
fix integration tests (because of types)
1 parent 158c374 commit 9c1fafb

File tree

1 file changed

+35
-35
lines changed

1 file changed

+35
-35
lines changed

packages/cubejs-schema-compiler/test/integration/postgres/cube-views.test.ts

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -444,13 +444,13 @@ view(\`OrdersViewDrillMembersWithPrefix\`, {
444444
it('check includes are exposed in meta', async () => {
445445
await compiler.compile();
446446
const cube = metaTransformer.cubes.find(c => c.config.name === 'OrdersView');
447-
expect(cube.config.measures.find((({ name }) => name === 'OrdersView.count')).name).toBe('OrdersView.count');
447+
expect(cube?.config.measures.find((({ name }) => name === 'OrdersView.count'))?.name).toBe('OrdersView.count');
448448
});
449449

450450
it('orders are hidden', async () => {
451451
await compiler.compile();
452452
const cube = metaTransformer.cubes.find(c => c.config.name === 'Orders');
453-
expect(cube.config.measures.filter((({ isVisible }) => isVisible)).length).toBe(0);
453+
expect(cube?.config.measures.filter((({ isVisible }) => isVisible)).length).toBe(0);
454454
});
455455

456456
it('split views', async () => runQueryTest({
@@ -465,9 +465,9 @@ view(\`OrdersViewDrillMembersWithPrefix\`, {
465465
it('check drillMembers are inherited in views', async () => {
466466
await compiler.compile();
467467
const cube = metaTransformer.cubes.find(c => c.config.name === 'OrdersView');
468-
const countMeasure = cube.config.measures.find((m) => m.name === 'OrdersView.count');
469-
expect(countMeasure.drillMembers).toEqual(['OrdersView.id', 'OrdersView.ProductCategories_name']);
470-
expect(countMeasure.drillMembersGrouped).toEqual({
468+
const countMeasure = cube?.config.measures.find((m) => m.name === 'OrdersView.count');
469+
expect(countMeasure?.drillMembers).toEqual(['OrdersView.id', 'OrdersView.ProductCategories_name']);
470+
expect(countMeasure?.drillMembersGrouped).toEqual({
471471
measures: [],
472472
dimensions: ['OrdersView.id', 'OrdersView.ProductCategories_name']
473473
});
@@ -478,18 +478,18 @@ view(\`OrdersViewDrillMembersWithPrefix\`, {
478478

479479
// Check that the source Orders cube has drill members
480480
const sourceOrdersCube = metaTransformer.cubes.find(c => c.config.name === 'Orders');
481-
const sourceCountMeasure = sourceOrdersCube.config.measures.find((m) => m.name === 'Orders.count');
482-
expect(sourceCountMeasure.drillMembers).toEqual(['Orders.id', 'Orders.createdAt', 'ProductCategories.name']);
481+
const sourceCountMeasure = sourceOrdersCube?.config.measures.find((m) => m.name === 'Orders.count');
482+
expect(sourceCountMeasure?.drillMembers).toEqual(['Orders.id', 'Orders.createdAt', 'ProductCategories.name']);
483483

484484
// Check that the OrdersView cube inherits these drill members with correct naming
485485
const viewCube = metaTransformer.cubes.find(c => c.config.name === 'OrdersView');
486-
const viewCountMeasure = viewCube.config.measures.find((m) => m.name === 'OrdersView.count');
486+
const viewCountMeasure = viewCube?.config.measures.find((m) => m.name === 'OrdersView.count');
487487

488-
expect(viewCountMeasure.drillMembers).toBeDefined();
489-
expect(Array.isArray(viewCountMeasure.drillMembers)).toBe(true);
490-
expect(viewCountMeasure.drillMembers.length).toBeGreaterThan(0);
491-
expect(viewCountMeasure.drillMembers).toContain('OrdersView.id');
492-
expect(viewCountMeasure.drillMembersGrouped).toBeDefined();
488+
expect(viewCountMeasure?.drillMembers).toBeDefined();
489+
expect(Array.isArray(viewCountMeasure?.drillMembers)).toBe(true);
490+
expect(viewCountMeasure?.drillMembers.length).toBeGreaterThan(0);
491+
expect(viewCountMeasure?.drillMembers).toContain('OrdersView.id');
492+
expect(viewCountMeasure?.drillMembersGrouped).toBeDefined();
493493
});
494494

495495
it('check drill member inheritance with limited includes in OrdersSimpleView', async () => {
@@ -530,17 +530,17 @@ view(\`OrdersViewDrillMembersWithPrefix\`, {
530530
// Check that the OrdersView cube inherits these drill members with correct naming
531531
const viewCube = metaTransformer.cubes.find(c => c.config.name === 'OrdersViewDrillMembers');
532532

533-
const viewCountMeasure = viewCube.config.measures.find((m) => m.name === 'OrdersViewDrillMembers.count');
534-
expect(viewCountMeasure.drillMembers).toBeDefined();
535-
expect(Array.isArray(viewCountMeasure.drillMembers)).toBe(true);
536-
expect(viewCountMeasure.drillMembers.length).toEqual(2);
537-
expect(viewCountMeasure.drillMembers).toEqual(['OrdersViewDrillMembers.createdAt', 'OrdersViewDrillMembers.name']);
538-
539-
const viewCount2Measure = viewCube.config.measures.find((m) => m.name === 'OrdersViewDrillMembers.count2');
540-
expect(viewCount2Measure.drillMembers).toBeDefined();
541-
expect(Array.isArray(viewCount2Measure.drillMembers)).toBe(true);
542-
expect(viewCount2Measure.drillMembers.length).toEqual(1);
543-
expect(viewCount2Measure.drillMembers).toContain('OrdersViewDrillMembers.name');
533+
const viewCountMeasure = viewCube?.config.measures.find((m) => m.name === 'OrdersViewDrillMembers.count');
534+
expect(viewCountMeasure?.drillMembers).toBeDefined();
535+
expect(Array.isArray(viewCountMeasure?.drillMembers)).toBe(true);
536+
expect(viewCountMeasure?.drillMembers.length).toEqual(2);
537+
expect(viewCountMeasure?.drillMembers).toEqual(['OrdersViewDrillMembers.createdAt', 'OrdersViewDrillMembers.name']);
538+
539+
const viewCount2Measure = viewCube?.config.measures.find((m) => m.name === 'OrdersViewDrillMembers.count2');
540+
expect(viewCount2Measure?.drillMembers).toBeDefined();
541+
expect(Array.isArray(viewCount2Measure?.drillMembers)).toBe(true);
542+
expect(viewCount2Measure?.drillMembers.length).toEqual(1);
543+
expect(viewCount2Measure?.drillMembers).toContain('OrdersViewDrillMembers.name');
544544
});
545545

546546
it('verify drill member inheritance functionality (with transitive joins + prefix)', async () => {
@@ -549,16 +549,16 @@ view(\`OrdersViewDrillMembersWithPrefix\`, {
549549
// Check that the OrdersView cube inherits these drill members with correct naming
550550
const viewCube = metaTransformer.cubes.find(c => c.config.name === 'OrdersViewDrillMembersWithPrefix');
551551

552-
const viewCountMeasure = viewCube.config.measures.find((m) => m.name === 'OrdersViewDrillMembersWithPrefix.count');
553-
expect(viewCountMeasure.drillMembers).toBeDefined();
554-
expect(Array.isArray(viewCountMeasure.drillMembers)).toBe(true);
555-
expect(viewCountMeasure.drillMembers.length).toEqual(2);
556-
expect(viewCountMeasure.drillMembers).toEqual(['OrdersViewDrillMembersWithPrefix.createdAt', 'OrdersViewDrillMembersWithPrefix.ProductCategories_name']);
557-
558-
const viewCount2Measure = viewCube.config.measures.find((m) => m.name === 'OrdersViewDrillMembersWithPrefix.ProductCategories_count2');
559-
expect(viewCount2Measure.drillMembers).toBeDefined();
560-
expect(Array.isArray(viewCount2Measure.drillMembers)).toBe(true);
561-
expect(viewCount2Measure.drillMembers.length).toEqual(1);
562-
expect(viewCount2Measure.drillMembers).toContain('OrdersViewDrillMembersWithPrefix.ProductCategories_name');
552+
const viewCountMeasure = viewCube?.config.measures.find((m) => m.name === 'OrdersViewDrillMembersWithPrefix.count');
553+
expect(viewCountMeasure?.drillMembers).toBeDefined();
554+
expect(Array.isArray(viewCountMeasure?.drillMembers)).toBe(true);
555+
expect(viewCountMeasure?.drillMembers.length).toEqual(2);
556+
expect(viewCountMeasure?.drillMembers).toEqual(['OrdersViewDrillMembersWithPrefix.createdAt', 'OrdersViewDrillMembersWithPrefix.ProductCategories_name']);
557+
558+
const viewCount2Measure = viewCube?.config.measures.find((m) => m.name === 'OrdersViewDrillMembersWithPrefix.ProductCategories_count2');
559+
expect(viewCount2Measure?.drillMembers).toBeDefined();
560+
expect(Array.isArray(viewCount2Measure?.drillMembers)).toBe(true);
561+
expect(viewCount2Measure?.drillMembers.length).toEqual(1);
562+
expect(viewCount2Measure?.drillMembers).toContain('OrdersViewDrillMembersWithPrefix.ProductCategories_name');
563563
});
564564
});

0 commit comments

Comments
 (0)