duplicate names

Author: vasilev-alex

packages/cubejs-schema-compiler/src/compiler/CubeEvaluator.ts

@@ -217,6 +217,9 @@ export class CubeEvaluator extends CubeSymbols {
     const uniqueHierarchyNames = new Set();
     if (Array.isArray(cube.hierarchies)) {
       cube.hierarchies = cube.hierarchies.map(hierarchy => {
+        if (uniqueHierarchyNames.has(hierarchy.name)) {
+          errorReporter.error(`Duplicate hierarchy name '${hierarchy.name}' in cube '${cube.name}'`);
+        }
         uniqueHierarchyNames.add(hierarchy.name);
 
         return ({

packages/cubejs-schema-compiler/src/compiler/CubeValidator.ts

@@ -759,7 +759,7 @@ const cubeSchema = inherit(baseSchema, {
   sql: Joi.func(),
   sqlTable: Joi.func(),
   hierarchies: Joi.array().items(Joi.object().keys({
-    name: Joi.string().required(),
+    name: identifier,
     title: Joi.string(),
     public: Joi.boolean().strict(),
     levels: Joi.func()

packages/cubejs-schema-compiler/test/unit/fixtures/hierarchies.yml

@@ -28,6 +28,7 @@ cubes:
         type: string
     hierarchies:
       - name: orders_hierarchy
+        title: Hello Hierarchy
         levels:
           - "{CUBE}.status"
           - number

packages/cubejs-schema-compiler/test/unit/hierarchies.test.ts

@@ -21,6 +21,7 @@ describe('Cube hierarchies', () => {
     expect(ordersView.config.hierarchies).toEqual([
       {
         name: 'orders_users_view.orders_hierarchy',
+        title: 'Hello Hierarchy',
         public: true,
         levels: [
           'orders_users_view.status',
@@ -60,4 +61,45 @@ describe('Cube hierarchies', () => {
 
     await expect(compiler.compile()).rejects.toThrow('Only dimensions can be part of a hierarchy. Please remove the \'count\' member from the \'orders_hierarchy\' hierarchy.');
   });
+
+  it(('does not accept wrong name'), async () => {
+    const { compiler } = prepareYamlCompiler(`cubes:
+  - name: orders
+    sql_table: orders
+    dimensions:
+      - name: id
+        sql: id
+        type: number
+        primary_key: true
+
+    hierarchies:
+      - name: hello wrong name
+        levels:
+          - id
+`);
+
+    await expect(compiler.compile()).rejects.toThrow('with value "hello wrong name" fails to match the identifier pattern');
+  });
+
+  it(('duplicated hierarchy'), async () => {
+    const { compiler } = prepareYamlCompiler(`cubes:
+      - name: orders
+        sql_table: orders
+        dimensions:
+          - name: id
+            sql: id
+            type: number
+            primary_key: true
+
+        hierarchies:
+          - name: test_hierarchy
+            levels:
+              - id
+          - name: test_hierarchy
+            levels:
+              - id
+    `);
+
+    await expect(compiler.compile()).rejects.toThrow('Duplicate hierarchy name \'test_hierarchy\' in cube \'orders\'');
+  });
 });