Skip to content

Commit a41efc3

Browse files
committed
fix(cubejs-playground): update query builder * 3
1 parent d5cdc04 commit a41efc3

File tree

1 file changed

+17
-10
lines changed

1 file changed

+17
-10
lines changed

packages/cubejs-playground/src/hooks/server-core-version.ts

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,25 @@ export function useServerCoreVersionGte(version: string): boolean {
44
const { serverCoreVersion = '', coreServerVersion = '' } =
55
usePlaygroundContext();
66

7-
let gt = false;
7+
const coreVersion = serverCoreVersion || coreServerVersion;
88

9-
try {
10-
const [, m, p] = (serverCoreVersion || coreServerVersion)
11-
.split('.')
12-
.map(Number);
13-
const [, m1, p1] = version.split('.').map(Number);
9+
if (coreVersion) {
10+
let gt = false;
1411

15-
gt = m > m1 || (m === m1 && p >= p1);
16-
} catch (_) {
17-
//
12+
try {
13+
const [major, minor, patch] = coreVersion.split('.').map(Number);
14+
const [major1, minor1, patch1] = version.split('.').map(Number);
15+
16+
gt =
17+
major > major1 ||
18+
(major === major1 && minor > minor1) ||
19+
(major === major1 && minor === minor1 && patch >= patch1);
20+
} catch (_) {
21+
//
22+
}
23+
24+
return gt;
1825
}
1926

20-
return gt;
27+
return true;
2128
}

0 commit comments

Comments
 (0)