refactor(cubesql): Use &str instead of &String

Author: mcheshkov

packages/cubejs-backend-native/src/node_export.rs

@@ -183,7 +183,7 @@ async fn handle_sql_query(
     native_auth_ctx: Arc<NativeAuthContext>,
     channel: Arc<Channel>,
     stream_methods: WritableStreamMethods,
-    sql_query: &String,
+    sql_query: &str,
 ) -> Result<(), CubeError> {
     let config = services
         .injector()

rust/cubesql/cubesql/src/compile/parser.rs

@@ -41,16 +41,16 @@ static SIGMA_WORKAROUND: LazyLock<Regex> = LazyLock::new(|| {
 });
 
 pub fn parse_sql_to_statements(
-    query: &String,
+    query: &str,
     protocol: DatabaseProtocol,
     qtrace: &mut Option<Qtrace>,
 ) -> CompilationResult<Vec<Statement>> {
-    let original_query = query.clone();
+    let original_query = query;
 
     log::debug!("Parsing SQL: {}", query);
     // @todo Support without workarounds
     // metabase
-    let query = query.clone().replace("IF(TABLE_TYPE='BASE TABLE' or TABLE_TYPE='SYSTEM VERSIONED', 'TABLE', TABLE_TYPE) as TABLE_TYPE", "TABLE_TYPE");
+    let query = query.replace("IF(TABLE_TYPE='BASE TABLE' or TABLE_TYPE='SYSTEM VERSIONED', 'TABLE', TABLE_TYPE) as TABLE_TYPE", "TABLE_TYPE");
     let query = query.replace("ORDER BY TABLE_TYPE, TABLE_SCHEMA, TABLE_NAME", "");
     // @todo Implement CONVERT function
     let query = query.replace("CONVERT (CASE DATA_TYPE WHEN 'year' THEN NUMERIC_SCALE WHEN 'tinyint' THEN 0 ELSE NUMERIC_SCALE END, UNSIGNED INTEGER)", "0");
@@ -247,13 +247,14 @@ pub fn parse_sql_to_statements(
     };
 
     parse_result.map_err(|err| {
-        CompilationError::user(format!("Unable to parse: {:?}", err))
-            .with_meta(Some(HashMap::from([("query".to_string(), original_query)])))
+        CompilationError::user(format!("Unable to parse: {:?}", err)).with_meta(Some(
+            HashMap::from([("query".to_string(), original_query.to_string())]),
+        ))
     })
 }
 
 pub fn parse_sql_to_statement(
-    query: &String,
+    query: &str,
     protocol: DatabaseProtocol,
     qtrace: &mut Option<Qtrace>,
 ) -> CompilationResult<Statement> {
@@ -274,7 +275,10 @@ pub fn parse_sql_to_statement(
                     ))
                 };
 
-                Err(err.with_meta(Some(HashMap::from([("query".to_string(), query.clone())]))))
+                Err(err.with_meta(Some(HashMap::from([(
+                    "query".to_string(),
+                    query.to_string(),
+                )]))))
             }
         }
     }

rust/cubesql/cubesql/src/compile/router.rs

@@ -637,7 +637,7 @@ pub async fn convert_statement_to_cube_query(
 }
 
 pub async fn convert_sql_to_cube_query(
-    query: &String,
+    query: &str,
     meta: Arc<MetaContext>,
     session: Arc<Session>,
 ) -> CompilationResult<QueryPlan> {

rust/cubesql/cubesql/src/sql/postgres/shim.rs

@@ -1792,8 +1792,7 @@ impl AsyncPostgresShim {
         let cache_entry = self.get_cache_entry().await?;
         let meta = self.session.server.compiler_cache.meta(cache_entry).await?;
 
-        let statements =
-            parse_sql_to_statements(&query.to_string(), DatabaseProtocol::PostgreSQL, qtrace)?;
+        let statements = parse_sql_to_statements(query, DatabaseProtocol::PostgreSQL, qtrace)?;
 
         if statements.len() == 0 {
             self.write(protocol::EmptyQuery::new()).await?;