Skip to content

Commit a8476d9

Browse files
committed
fix
1 parent a92967f commit a8476d9

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,12 +721,12 @@ export class BaseQuery {
721721
return this.paramAllocator.getParams();
722722
}
723723

724-
// FIXME helper for native generator, maybe should be moved entire to rust
724+
// FIXME helper for native generator, maybe should be moved entirely to rust
725725
generateTimeSeries(granularity, dateRange) {
726726
return timeSeriesBase(granularity, dateRange);
727727
}
728728

729-
// FIXME helper for native generator, maybe should be moved entire to rust
729+
// FIXME helper for native generator, maybe should be moved entirely to rust
730730
generateCustomTimeSeries(granularityInterval, dateRange, origin) {
731731
return timeSeriesFromCustomInterval(granularityInterval, dateRange, moment(origin), { timestampPrecision: 3 });
732732
}

rust/cubesqlplanner/cubesqlplanner/src/planner/base_time_dimension.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ impl BaseTimeDimension {
162162
self.date_range.clone()
163163
}
164164

165-
pub fn get_range_for_time_seiories(&self) -> Result<Option<(String, String)>, CubeError> {
165+
pub fn get_range_for_time_series(&self) -> Result<Option<(String, String)>, CubeError> {
166166
let res = if let Some(date_range) = &self.date_range {
167167
if date_range.len() != 2 {
168168
return Err(CubeError::user(format!(

rust/cubesqlplanner/cubesqlplanner/src/planner/planners/multi_stage/member_query_planner.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl MultiStageMemberQueryPlanner {
125125
let templates = PlanSqlTemplates::new(self.query_tools.templates_render());
126126

127127
let ts_date_range = if templates.supports_generated_time_series() {
128-
if let Some(date_range) = time_dimension.get_range_for_time_seiories()? {
128+
if let Some(date_range) = time_dimension.get_range_for_time_series()? {
129129
TimeSeriesDateRange::Filter(date_range.0.clone(), date_range.1.clone())
130130
} else {
131131
if let Some(date_range_cte) = &time_series_description.date_range_cte {

rust/cubesqlplanner/cubesqlplanner/src/planner/sql_evaluator/dependecy.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ impl<'a> DependenciesBuilder<'a> {
108108
result.push(Dependency::SymbolDependency(
109109
self.build_evaluator(&cube_name, &dep.name)?,
110110
));
111-
} else if self.check_if_it_cube(&dep.name)? {
111+
} else if self.check_cube_exists(&dep.name)? {
112112
let dep = self.build_cube_dependency(&cube_name, i, &call_deps, &childs)?;
113113
result.push(Dependency::CubeDependency(dep));
114114
} else {
@@ -150,7 +150,7 @@ impl<'a> DependenciesBuilder<'a> {
150150
Ok(childs_tree)
151151
}
152152

153-
fn check_if_it_cube(&self, cube_name: &String) -> Result<bool, CubeError> {
153+
fn check_cube_exists(&self, cube_name: &String) -> Result<bool, CubeError> {
154154
if self.is_current_cube(cube_name) {
155155
Ok(true)
156156
} else {
@@ -232,7 +232,7 @@ impl<'a> DependenciesBuilder<'a> {
232232
} else {
233233
let child_dep = if call_childs[*child_ind].is_empty() {
234234
CubeDepProperty::SymbolDependency(self.build_evaluator(&new_cube_name, &name)?)
235-
} else if self.check_if_it_cube(name)? {
235+
} else if self.check_cube_exists(name)? {
236236
CubeDepProperty::CubeDependency(self.build_cube_dependency(
237237
&new_cube_name,
238238
*child_ind,

0 commit comments

Comments
 (0)