Skip to content

Commit a8c0a74

Browse files
committed
refactor(cubesql): Make var_iter and var_list_iter more hygienic
1 parent a7bab04 commit a8c0a74

File tree

14 files changed

+18
-20
lines changed

14 files changed

+18
-20
lines changed

rust/cubesql/cubesql/src/compile/rewrite/mod.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,9 @@ crate::plan_to_language! {
500500
macro_rules! var_iter {
501501
($eclass:expr, $field_variant:ident) => {{
502502
$eclass.nodes.iter().filter_map(|node| match node {
503-
LogicalPlanLanguage::$field_variant($field_variant(v)) => Some(v),
503+
$crate::compile::rewrite::LogicalPlanLanguage::$field_variant($field_variant(v)) => {
504+
Some(v)
505+
}
504506
_ => None,
505507
})
506508
}};
@@ -510,7 +512,7 @@ macro_rules! var_iter {
510512
macro_rules! var_list_iter {
511513
($eclass:expr, $field_variant:ident) => {{
512514
$eclass.nodes.iter().filter_map(|node| match node {
513-
LogicalPlanLanguage::$field_variant(v) => Some(v),
515+
$crate::compile::rewrite::LogicalPlanLanguage::$field_variant(v) => Some(v),
514516
_ => None,
515517
})
516518
}};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/aggregate_function.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
AggregateFunctionExprDistinct, AggregateFunctionExprFun, LogicalPlanLanguage,
8-
WrapperPullupReplacerAliasToCube,
7+
AggregateFunctionExprDistinct, AggregateFunctionExprFun, WrapperPullupReplacerAliasToCube,
98
},
109
var, var_iter,
1110
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/binary_expr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LogicalPlanLanguage, WrapperPullupReplacerAliasToCube,
7+
WrapperPullupReplacerAliasToCube,
88
},
99
var, var_iter,
1010
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/case.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LogicalPlanLanguage, WrapperPullupReplacerAliasToCube,
7+
WrapperPullupReplacerAliasToCube,
88
},
99
var, var_iter,
1010
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/extract.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ use crate::{
33
literal_expr,
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
6-
transforming_rewrite, wrapper_pullup_replacer, LogicalPlanLanguage,
7-
WrapperPullupReplacerAliasToCube,
6+
transforming_rewrite, wrapper_pullup_replacer, WrapperPullupReplacerAliasToCube,
87
},
98
var, var_iter,
109
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/in_list_expr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LogicalPlanLanguage, WrapperPullupReplacerAliasToCube,
7+
WrapperPullupReplacerAliasToCube,
88
},
99
var, var_iter,
1010
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/is_null_expr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LogicalPlanLanguage, WrapperPullupReplacerAliasToCube,
7+
WrapperPullupReplacerAliasToCube,
88
},
99
var, var_iter,
1010
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/like_expr.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LikeExprEscapeChar, LikeExprLikeType, LikeType, LogicalPlanLanguage,
8-
WrapperPullupReplacerAliasToCube,
7+
LikeExprEscapeChar, LikeExprLikeType, LikeType, WrapperPullupReplacerAliasToCube,
98
},
109
var, var_iter,
1110
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/negative_expr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LogicalPlanLanguage, WrapperPullupReplacerAliasToCube,
7+
WrapperPullupReplacerAliasToCube,
88
},
99
var, var_iter,
1010
};

rust/cubesql/cubesql/src/compile/rewrite/rules/wrapper/not_expr.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::{
44
rewriter::{CubeEGraph, CubeRewrite},
55
rules::wrapper::WrapperRules,
66
transforming_rewrite, wrapper_pullup_replacer, wrapper_pushdown_replacer,
7-
LogicalPlanLanguage, WrapperPullupReplacerAliasToCube,
7+
WrapperPullupReplacerAliasToCube,
88
},
99
var, var_iter,
1010
};

0 commit comments

Comments
 (0)