fix(cubesql): Cannot read properties of undefined (reading 'preAggregation') with enabled SQL push down

paveltiunov · paveltiunov · commit ac2cc177fc5d · 2024-02-13T13:57:51.000-08:00
diff --git a/packages/cubejs-schema-compiler/src/adapter/BaseQuery.js b/packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
@@ -468,7 +468,7 @@ export class BaseQuery {
     if (!this.options.preAggregationQuery && !this.ungrouped) {
       preAggForQuery =
         this.preAggregations.findPreAggregationForQuery();
-      if (this.options.disableExternalPreAggregations && preAggForQuery.preAggregation.external) {
+      if (this.options.disableExternalPreAggregations && preAggForQuery && preAggForQuery.preAggregation.external) {
         preAggForQuery = undefined;
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -468,7 +468,7 @@ export class BaseQuery {`
`468`	`468`	`if (!this.options.preAggregationQuery && !this.ungrouped) {`
`469`	`469`	`preAggForQuery =`
`470`	`470`	`this.preAggregations.findPreAggregationForQuery();`
`471`		`- if (this.options.disableExternalPreAggregations && preAggForQuery.preAggregation.external) {`
	`471`	`+ if (this.options.disableExternalPreAggregations && preAggForQuery && preAggForQuery.preAggregation.external) {`
`472`	`472`	`preAggForQuery = undefined;`
`473`	`473`	`}`
`474`	`474`	`}`