Skip to content

Commit b08e27b

Browse files
authored
fix(playground): rollup designer view members (#7214)
1 parent 979fa43 commit b08e27b

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

packages/cubejs-client-core/index.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,9 @@ declare module '@cubejs-client/core' {
153153
sortedDimensions: string[];
154154
sortedTimeDimensions: [[string, string]];
155155
measureToLeafMeasures?: Record<string, LeafMeasure[]>;
156+
ownedDimensions: string[];
157+
ownedTimeDimensionsAsIs: [[string, string | null]];
158+
ownedTimeDimensionsWithRollupGranularity: [[string, string]];
156159
};
157160

158161
export type PreAggregationType = 'rollup' | 'rollupJoin' | 'rollupLambda' | 'originalSql';

packages/cubejs-playground/src/rollup-designer/RollupDesigner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ export function RollupDesigner({
229229
if (transformedQuery) {
230230
cubeName = (
231231
transformedQuery?.leafMeasures[0] ||
232-
transformedQuery?.sortedDimensions[0] ||
232+
transformedQuery?.ownedDimensions[0] ||
233233
'CubeName'
234234
).split('.')[0];
235235
} else if (!areReferencesEmpty(references)) {

packages/cubejs-playground/src/rollup-designer/utils.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,19 @@ export function getPreAggregationReferences(
4444
references.measures = [...transformedQuery.leafMeasures];
4545
}
4646

47-
if (transformedQuery.sortedDimensions.length) {
47+
if (transformedQuery.ownedDimensions.length) {
4848
references.dimensions = [
49-
...transformedQuery.sortedDimensions.filter(
49+
...transformedQuery.ownedDimensions.filter(
5050
(name) => !segments.has(name)
5151
),
5252
];
5353
references.segments = [
54-
...transformedQuery.sortedDimensions.filter((name) => segments.has(name)),
54+
...transformedQuery.ownedDimensions.filter((name) => segments.has(name)),
5555
];
5656
}
5757

58-
if (transformedQuery.sortedTimeDimensions?.[0]?.[0]) {
59-
const [dimension, granularity] = transformedQuery.sortedTimeDimensions[0];
58+
if (transformedQuery.ownedTimeDimensionsWithRollupGranularity?.[0]?.[0]) {
59+
const [dimension, granularity] = transformedQuery.ownedTimeDimensionsWithRollupGranularity[0];
6060
references.timeDimensions = [
6161
{
6262
dimension,

0 commit comments

Comments
 (0)