feat(cubesql): Support SQL push down for more functions (#7406)

* feat(cubesql): Add `PI` function

* chore(cubesql): Add `GREATEST` function stub

* fix(cubesql): Fix `IS NOT NULL` push down

* feat(cubesql): Support SQL push down for more functions

Author: MazterQyou

packages/cubejs-backend-native/Cargo.lock

@@ -2455,11 +2455,15 @@ class BaseQuery {
         EXP: 'EXP({{ args_concat }})',
         LN: 'LN({{ args_concat }})',
         LOG: 'LOG({{ args_concat }})',
+        DLOG10: 'LOG10({{ args_concat }})',
         PI: 'PI()',
         POWER: 'POWER({{ args_concat }})',
         SIN: 'SIN({{ args_concat }})',
         TAN: 'TAN({{ args_concat }})',
         REPEAT: 'REPEAT({{ args_concat }})',
+        NULLIF: 'NULLIF({{ args_concat }})',
+        ROUND: 'ROUND({{ args_concat }})',
+        GREATEST: 'GREATEST({{ args_concat }})',
 
         STDDEV: 'STDDEV_SAMP({{ args_concat }})',
         SUBSTR: 'SUBSTRING({{ args_concat }})',
@@ -2475,7 +2479,7 @@ class BaseQuery {
       expressions: {
         column_aliased: '{{expr}} {{quoted_alias}}',
         case: 'CASE{% if expr %}{{ expr }} {% endif %}{% for when, then in when_then %} WHEN {{ when }} THEN {{ then }}{% endfor %}{% if else_expr %} ELSE {{ else_expr }}{% endif %} END',
-        is_null: '{{ expr }} {% if negate %}NOT {% endif %}IS NULL',
+        is_null: '{{ expr }} IS {% if negate %}NOT {% endif %}NULL',
         binary: '({{ left }} {{ op }} {{ right }})',
         sort: '{{ expr }} {% if asc %}ASC{% else %}DESC{% endif %}{% if nulls_first %} NULLS FIRST{% endif %}',
         cast: 'CAST({{ expr }} AS {{ data_type }})',

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -150,6 +150,7 @@ export class BigqueryQuery extends BaseQuery {
     templates.quotes.identifiers = '`';
     templates.quotes.escape = '\\`';
     templates.functions.DATETRUNC = 'DATETIME_TRUNC(CAST({{ args[1] }} AS DATETIME), {{ date_part }})';
+    templates.functions.LOG = 'LOG({{ args_concat }}{% if args[1] is undefined %}, 10{% endif %})';
     templates.expressions.binary = '{% if op == \'%\' %}MOD({{ left }}, {{ right }}){% else %}({{ left }} {{ op }} {{ right }}){% endif %}';
     templates.expressions.interval = 'INTERVAL {{ interval }}';
     templates.expressions.extract = 'EXTRACT({% if date_part == \'DOW\' %}DAYOFWEEK{% elif date_part == \'DOY\' %}DAYOFYEAR{% else %}{{ date_part }}{% endif %} FROM {{ expr }})';

packages/cubejs-schema-compiler/src/adapter/BigqueryQuery.js

@@ -17,6 +17,7 @@ export class RedshiftQuery extends PostgresQuery {
       ...super.sqlTemplates(),
       COVAR_POP: undefined,
       COVAR_SAMP: undefined,
+      DLOG10: 'LOG(10, {{ args_concat }})',
     };
   }
 }

packages/cubejs-schema-compiler/src/adapter/RedshiftQuery.js

@@ -54,6 +54,8 @@ export class SnowflakeQuery extends BaseQuery {
     const templates = super.sqlTemplates();
     templates.functions.DATETRUNC = 'DATE_TRUNC({{ args_concat }})';
     templates.functions.DATEPART = 'DATE_PART({{ args_concat }})';
+    templates.functions.LOG = 'LOG({% if args[1] is undefined %}10, {% endif %}{{ args_concat }})';
+    templates.functions.DLOG10 = 'LOG(10, {{ args_concat }})';
     templates.expressions.extract = 'EXTRACT({{ date_part }} FROM {{ expr }})';
     templates.expressions.interval = 'INTERVAL \'{{ interval }}\'';
     return templates;

packages/cubejs-schema-compiler/src/adapter/SnowflakeQuery.js

@@ -10,7 +10,7 @@ homepage = "https://cube.dev"
 
 [dependencies]
 arc-swap = "1"
-datafusion = { git = 'https://github.com/cube-js/arrow-datafusion.git', rev = "be967a63967f23bdd946a45925d07af0a11dcc39", default-features = false, features = ["regex_expressions", "unicode_expressions"] }
+datafusion = { git = 'https://github.com/cube-js/arrow-datafusion.git', rev = "3fb79c32defa4ec39ccf658b6185704d1980f228", default-features = false, features = ["regex_expressions", "unicode_expressions"] }
 anyhow = "1.0"
 thiserror = "1.0"
 cubeclient = { path = "../cubeclient" }

rust/cubesql/Cargo.lock

@@ -3634,6 +3634,7 @@ pub fn register_fun_stubs(mut ctx: SessionContext) -> SessionContext {
         rettyp = Int64,
         vol = Volatile
     );
+    register_fun_stub!(udf, "greatest", argc = 2);
     register_fun_stub!(
         udf,
         "has_any_column_privilege",

rust/cubesql/cubesql/Cargo.toml

@@ -19629,4 +19629,18 @@ ORDER BY \"COUNT(count)\" DESC"
             .sql
             .contains("NOT IN ("));
     }
+
+    #[tokio::test]
+    async fn test_pi() -> Result<(), CubeError> {
+        insta::assert_snapshot!(
+            "pi",
+            execute_query(
+                "SELECT PI() AS PI".to_string(),
+                DatabaseProtocol::PostgreSQL
+            )
+            .await?
+        );
+
+        Ok(())
+    }
 }

rust/cubesql/cubesql/src/compile/engine/udf.rs

@@ -356,6 +356,7 @@ macro_rules! variant_field_struct {
                 BuiltinScalarFunction::MD5 => "MD5",
                 BuiltinScalarFunction::NullIf => "NullIf",
                 BuiltinScalarFunction::OctetLength => "OctetLength",
+                BuiltinScalarFunction::Pi => "Pi",
                 BuiltinScalarFunction::Random => "Random",
                 BuiltinScalarFunction::RegexpReplace => "RegexpReplace",
                 BuiltinScalarFunction::Repeat => "Repeat",