Skip to content

Commit b21ebfa

Browse files
committed
remove obsolete continueWait flag
1 parent 749f039 commit b21ebfa

File tree

4 files changed

+1
-12
lines changed

4 files changed

+1
-12
lines changed

packages/cubejs-api-gateway/src/gateway.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,7 +1653,6 @@ class ApiGateway {
16531653
...sqlQuery,
16541654
query: sqlQuery.sql[0],
16551655
values: sqlQuery.sql[1],
1656-
continueWait: true,
16571656
renewQuery: normalizedQuery.renewQuery,
16581657
cacheMode,
16591658
requestId: context.requestId,
@@ -1678,7 +1677,6 @@ class ApiGateway {
16781677
...totalQuery,
16791678
query: totalQuery.sql[0],
16801679
values: totalQuery.sql[1],
1681-
continueWait: true,
16821680
renewQuery: normalizedTotal.renewQuery,
16831681
cacheMode,
16841682
requestId: context.requestId,
@@ -1800,7 +1798,6 @@ class ApiGateway {
18001798
...sqlQuery,
18011799
query: sqlQuery.sql[0],
18021800
values: sqlQuery.sql[1],
1803-
continueWait: true,
18041801
renewQuery: false,
18051802
cacheMode: 'stale-if-slow',
18061803
requestId: context.requestId,
@@ -1995,7 +1992,6 @@ class ApiGateway {
19951992
...sqlQuery,
19961993
query: sqlQuery.query || sqlQuery.sql[0],
19971994
values: sqlQuery.values || sqlQuery.sql[1],
1998-
continueWait: true,
19991995
renewQuery: false,
20001996
cacheMode: 'stale-if-slow',
20011997
requestId: context.requestId,
@@ -2015,7 +2011,6 @@ class ApiGateway {
20152011
const finalQuery: QueryBody = {
20162012
query: request.sqlQuery[0],
20172013
values: request.sqlQuery[1],
2018-
continueWait: true,
20192014
renewQuery: normalizedQueries[0].renewQuery,
20202015
cacheMode: request.cacheMode,
20212016
requestId: context.requestId,

packages/cubejs-query-orchestrator/src/orchestrator/QueryCache.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export type QueryBody = {
8282
values?: string[];
8383
loadRefreshKeysOnly?: boolean;
8484
scheduledRefresh?: boolean;
85-
continueWait?: boolean;
8685
// @deprecated
8786
renewQuery?: boolean;
8887
cacheMode?: CacheMode;

packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,6 @@ export class QueryOrchestrator {
408408

409409
const data = await this.fetchQuery({
410410
dataSource: preAggregation.dataSource,
411-
continueWait: true,
412411
query,
413412
external,
414413
preAggregations: [

packages/cubejs-server-core/src/core/RefreshScheduler.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,6 @@ export class RefreshScheduler {
368368
...sqlQuery,
369369
sql: null,
370370
preAggregations: [],
371-
continueWait: true,
372371
cacheMode: 'must-revalidate',
373372
requestId: context.requestId,
374373
scheduledRefresh: true,
@@ -579,7 +578,6 @@ export class RefreshScheduler {
579578
...partition,
580579
priority: preAggregationsWarmup ? 1 : queryCursor - queries.length
581580
})),
582-
continueWait: true,
583581
cacheMode: 'must-revalidate',
584582
requestId: context.requestId,
585583
timezone: timezones[timezoneCursor],
@@ -644,7 +642,6 @@ export class RefreshScheduler {
644642
Promise.all(partitions.map(async (partition) => {
645643
await orchestratorApi.executeQuery({
646644
preAggregations: dependencies.concat([partition]),
647-
continueWait: true,
648645
cacheMode: 'must-revalidate',
649646
forceBuildPreAggregations: queryingOptions.forceBuildPreAggregations ?? true,
650647
orphanedTimeout: 60 * 60,
@@ -738,8 +735,7 @@ export class RefreshScheduler {
738735
async (partition): Promise<JobedPreAggregation[]> => {
739736
const job = await orchestratorApi.executeQuery({
740737
preAggregations: dependencies.concat([partition]),
741-
continueWait: true,
742-
cacheMode: 'stale-while-revalidate',
738+
cacheMode: 'must-revalidate',
743739
forceBuildPreAggregations: true,
744740
orphanedTimeout: 60 * 60,
745741
requestId: context.requestId,

0 commit comments

Comments
 (0)