define types for TablesSchema query results

Author: KSDaemon

packages/cubejs-base-driver/src/BaseDriver.ts

@@ -52,6 +52,7 @@ import {
   TableMemoryData,
   PrimaryKeysQueryResult,
   ForeignKeysQueryResult,
+  DatabaseStructure,
 } from './driver.interface';
 
 /**
@@ -409,28 +410,28 @@ export abstract class BaseDriver implements DriverInterface {
     return false;
   }
 
-  protected informationColumnsSchemaReducer(result: any, i: any) {
+  protected informationColumnsSchemaReducer(result: any, i: any): DatabaseStructure {
     let schema = (result[i.table_schema] || {});
-    const tables = (schema[i.table_name] || []);
+    const columns = (schema[i.table_name] || []);
 
-    tables.push({
+    columns.push({
       name: i.column_name,
       type: i.data_type,
       attributes: i.key_type ? ['primaryKey'] : []
     });
 
-    tables.sort();
-    schema[i.table_name] = tables;
+    columns.sort();
+    schema[i.table_name] = columns;
     schema = sortByKeys(schema);
     result[i.table_schema] = schema;
 
     return sortByKeys(result);
   }
 
-  public tablesSchema(): Promise<any> {
+  public tablesSchema(): Promise<DatabaseStructure> {
     const query = this.informationSchemaQuery();
 
-    return this.query(query, []).then(data => data.reduce(this.informationColumnsSchemaReducer, {}));
+    return this.query(query, []).then(data => data.reduce<DatabaseStructure>(this.informationColumnsSchemaReducer, {}));
   }
 
   // Extended version of tablesSchema containing primary and foreign keys

packages/cubejs-base-driver/src/driver.interface.ts

@@ -2,9 +2,7 @@
 export type GenericDataBaseType = string;
 
 export interface TableColumn {
-  // eslint-disable-next-line camelcase
   name: string;
-  // eslint-disable-next-line camelcase
   type: GenericDataBaseType;
   attributes?: string[]
 }