cr comments fixes

Author: Tankilevitch

packages/cubejs-schema-compiler/src/adapter/OracleQuery.ts

@@ -82,7 +82,7 @@ export class OracleQuery extends BaseQuery {
   }
 
   public timeStampParam(timeDimension) {
-    return timeDimension.dateFieldType() === 'string' ? ':"?"' : this.dateTimeCast('?');
+    return timeDimension.dateFieldType() === 'string' ? ':"?"' : this.timeStampCast('?');
   }
 
   public timeGroupedColumn(granularity, dimension) {

packages/cubejs-schema-compiler/test/unit/oracle-query.test.ts

@@ -28,7 +28,7 @@ describe('OracleQuery', () => {
     })
     `, { adapter: 'oracle' });
 
-  it('uses TO_TIMESTAMP_TZ with milliseconds precision and preserves trailing Z', async () => {
+  it('generates TO_TIMESTAMP_TZ with millisecond precision for date range filters', async () => {
     await compiler.compile();
 
     const query = new OracleQuery(
@@ -48,7 +48,64 @@ describe('OracleQuery', () => {
 
     const [sql, params] = query.buildSqlAndParams();
 
+    // Verify TO_TIMESTAMP_TZ is used with proper ISO 8601 format including milliseconds
     expect(sql).toContain('TO_TIMESTAMP_TZ(:"?", \'YYYY-MM-DD"T"HH24:MI:SS.FF"Z"\')');
+    expect(sql).toMatch(/created_at\s+>=\s+TO_TIMESTAMP_TZ/);
+    expect(sql).toMatch(/created_at\s+<=\s+TO_TIMESTAMP_TZ/);
+    
+    // Verify parameters include millisecond precision
     expect(params).toEqual(['2024-02-01T00:00:00.000Z', '2024-02-02T23:59:59.999Z']);
   });
+
+  it('generates TRUNC function for day granularity grouping', async () => {
+    await compiler.compile();
+
+    const query = new OracleQuery(
+      { joinGraph, cubeEvaluator, compiler },
+      {
+        measures: ['visitors.count'],
+        timeDimensions: [
+          {
+            dimension: 'visitors.createdAt',
+            dateRange: ['2024-01-01', '2024-01-31'],
+            granularity: 'day'
+          }
+        ],
+        timezone: 'UTC'
+      }
+    );
+
+    const [sql, params] = query.buildSqlAndParams();
+
+    // Verify TRUNC with DD format for day grouping
+    expect(sql).toContain('TRUNC("visitors".created_at, \'DD\')');
+    expect(sql).toMatch(/GROUP BY\s+TRUNC/);
+    expect(params).toEqual(['2024-01-01T00:00:00.000Z', '2024-01-31T23:59:59.999Z']);
+  });
+
+  it('generates TRUNC function for month granularity grouping', async () => {
+    await compiler.compile();
+
+    const query = new OracleQuery(
+      { joinGraph, cubeEvaluator, compiler },
+      {
+        measures: ['visitors.count'],
+        timeDimensions: [
+          {
+            dimension: 'visitors.createdAt',
+            dateRange: ['2024-01-01', '2024-12-31'],
+            granularity: 'month'
+          }
+        ],
+        timezone: 'UTC'
+      }
+    );
+
+    const [sql, params] = query.buildSqlAndParams();
+
+    // Verify TRUNC with MM format for month grouping
+    expect(sql).toContain('TRUNC("visitors".created_at, \'MM\')');
+    expect(sql).toMatch(/GROUP BY\s+TRUNC/);
+    expect(params).toEqual(['2024-01-01T00:00:00.000Z', '2024-12-31T23:59:59.999Z']);
+  });
 });