more tests for folders

Author: KSDaemon

packages/cubejs-schema-compiler/test/unit/fixtures/folders_invalid_path.yml

@@ -0,0 +1,102 @@
+cubes:
+  - name: orders
+    sql: SELECT * FROM orders
+    joins:
+      - name: users
+        sql: "{CUBE}.order_id = {orders}.id"
+        relationship: many_to_one
+    measures:
+      - name: count
+        sql: id
+        type: count
+    dimensions:
+      - name: id
+        sql: id
+        type: number
+        primary_key: true
+
+      - name: number
+        sql: number
+        type: number
+
+      - name: status
+        sql: status
+        type: string
+    hierarchies:
+      - name: orders_hierarchy
+        levels:
+          - "{CUBE}.status"
+          - number
+          - users.city
+      - name: some_other_hierarchy
+        title: Some other hierarchy
+        levels:
+          - users.state
+          - users.city
+  #
+  - name: users
+    sql: SELECT * FROM users
+    hierarchies:
+      - name: users_hierarchy
+        levels:
+          - users.age
+          - city
+    dimensions:
+      - name: age
+        sql: age
+        type: number
+      - name: state
+        sql: state
+        type: string
+      - name: city
+        sql: city
+        type: string
+      - name: gender
+        sql: gender
+        type: string
+
+views:
+  - name: test_view
+    cubes:
+      - join_path: orders
+        includes: "*"
+      - join_path: users
+        includes:
+          - age
+          - state
+          - name: gender
+            alias: renamed_gender
+    folders:
+      - name: folder1
+        includes:
+          - age
+          - renamed_gender
+          - users.age
+      - name: folder2
+        includes: '*'
+  - name: test_view2
+    cubes:
+      - join_path: orders
+        alias: renamed_orders
+        prefix: true
+        includes: "*"
+      - join_path: users
+        prefix: true
+        includes:
+          - age
+          - state
+    folders:
+      - name: folder1
+        includes:
+          - users_age
+          - users_state
+          - renamed_orders_status
+  # - name: empty_view
+  #   cubes:
+  #     - join_path: orders
+  #       includes:
+  #         - count
+  #         - status
+
+
+

packages/cubejs-schema-compiler/test/unit/fixtures/folders_non_exist.yml

@@ -0,0 +1,102 @@
+cubes:
+  - name: orders
+    sql: SELECT * FROM orders
+    joins:
+      - name: users
+        sql: "{CUBE}.order_id = {orders}.id"
+        relationship: many_to_one
+    measures:
+      - name: count
+        sql: id
+        type: count
+    dimensions:
+      - name: id
+        sql: id
+        type: number
+        primary_key: true
+
+      - name: number
+        sql: number
+        type: number
+
+      - name: status
+        sql: status
+        type: string
+    hierarchies:
+      - name: orders_hierarchy
+        levels:
+          - "{CUBE}.status"
+          - number
+          - users.city
+      - name: some_other_hierarchy
+        title: Some other hierarchy
+        levels:
+          - users.state
+          - users.city
+  #
+  - name: users
+    sql: SELECT * FROM users
+    hierarchies:
+      - name: users_hierarchy
+        levels:
+          - users.age
+          - city
+    dimensions:
+      - name: age
+        sql: age
+        type: number
+      - name: state
+        sql: state
+        type: string
+      - name: city
+        sql: city
+        type: string
+      - name: gender
+        sql: gender
+        type: string
+
+views:
+  - name: test_view
+    cubes:
+      - join_path: orders
+        includes: "*"
+      - join_path: users
+        includes:
+          - age
+          - state
+          - name: gender
+            alias: renamed_gender
+    folders:
+      - name: folder1
+        includes:
+          - age
+          - renamed_gender
+          - non-existent
+      - name: folder2
+        includes: '*'
+  - name: test_view2
+    cubes:
+      - join_path: orders
+        alias: renamed_orders
+        prefix: true
+        includes: "*"
+      - join_path: users
+        prefix: true
+        includes:
+          - age
+          - state
+    folders:
+      - name: folder1
+        includes:
+          - users_age
+          - users_state
+          - renamed_orders_status
+  # - name: empty_view
+  #   cubes:
+  #     - join_path: orders
+  #       includes:
+  #         - count
+  #         - status
+
+
+

packages/cubejs-schema-compiler/test/unit/folders.test.ts

@@ -43,6 +43,23 @@ describe('Cube Folders', () => {
     );
   });
 
+  it('throws errors for folder members with path', async () => {
+    const modelContent = fs.readFileSync(
+      path.join(process.cwd(), '/test/unit/fixtures/folders_invalid_path.yml'),
+      'utf8'
+    );
+    // eslint-disable-next-line @typescript-eslint/no-shadow
+    const { compiler } = prepareYamlCompiler(modelContent);
+
+    try {
+      await compiler.compile();
+      throw new Error('should throw earlier');
+    } catch (e: any) {
+      expect(e.toString()).toMatch(/Paths aren't allowed in the 'folders' but 'users.age' has been provided for test_view/);
+      expect(e.toString()).toMatch(/Member 'users.age' included in folder 'folder1' not found/);
+    }
+  });
+
   it('a folder with aliased and prefixed cubes', async () => {
     const view = metaTransformer.cubes.find(
       (it) => it.config.name === 'test_view2'