Skip to content

Commit b9cf2bb

Browse files
committed
some improvements
1 parent 0f04b7e commit b9cf2bb

File tree

1 file changed

+6
-16
lines changed
  • rust/cubesql/cubesql/src/compile/rewrite/rules

1 file changed

+6
-16
lines changed

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -269,8 +269,8 @@ impl RewriteRules for MemberRules {
269269
"?members",
270270
"?filters",
271271
"?orders",
272-
"?limit",
273-
"?offset",
272+
"CubeScanLimit:None",
273+
"CubeScanOffset:None",
274274
"?split",
275275
"?can_pushdown_join",
276276
"CubeScanWrapped:false",
@@ -281,14 +281,14 @@ impl RewriteRules for MemberRules {
281281
"?members",
282282
"?filters",
283283
"?orders",
284-
"?limit",
285-
"?offset",
284+
"CubeScanLimit:None",
285+
"CubeScanOffset:None",
286286
"?split",
287287
"?can_pushdown_join",
288288
"CubeScanWrapped:false",
289289
"CubeScanUngrouped:false",
290290
),
291-
self.select_distinct_dimensions(/*"?members",*/ "?limit"),
291+
self.select_distinct_dimensions(/*"?members"*/),
292292
),
293293
// MOD function to binary expr
294294
transforming_rewrite_with_root(
@@ -1509,20 +1509,10 @@ impl MemberRules {
15091509
fn select_distinct_dimensions(
15101510
&self,
15111511
// members_var: &'static str,
1512-
limit_var: &'static str,
15131512
) -> impl Fn(&mut CubeEGraph, &mut Subst) -> bool {
15141513
// let members_var = var!(members_var);
1515-
let limit_var = var!(limit_var);
1516-
1517-
move |egraph, subst| {
1518-
let cube_limit = var_iter!(egraph[subst[limit_var]], CubeScanLimit)
1519-
.next()
1520-
.unwrap();
1521-
1522-
if cube_limit.is_some() {
1523-
return false;
1524-
}
15251514

1515+
move |_egraph, _subst| {
15261516
// for members in var_list_iter!(egraph[subst[members_var]], CubeScanMembers) {
15271517
// // TODO: check if all members in request are dimensions
15281518
// // If no - return false

0 commit comments

Comments
 (0)