fix(tesseract): Using FULL JOIN for outer aggregate joins in BigQuery

Author: waralexrom

packages/cubejs-schema-compiler/src/adapter/BigqueryQuery.ts

@@ -273,7 +273,6 @@ export class BigqueryQuery extends BaseQuery {
     templates.types.decimal = 'BIGDECIMAL({{ precision }},{{ scale }})';
     templates.types.binary = 'BYTES';
     templates.expressions.cast_to_string = 'CAST({{ expr }} AS STRING)';
-    templates.operators.is_not_distinct_from = 'IS NOT DISTINCT FROM';
     templates.join_types.full = 'FULL';
     templates.statements.time_series_select = 'SELECT DATETIME(TIMESTAMP(f)) date_from, DATETIME(TIMESTAMP(t)) date_to \n' +
     'FROM (\n' +

rust/cubesqlplanner/cubesqlplanner/src/physical_plan_builder/builder.rs

@@ -53,15 +53,15 @@ impl PhysicalPlanBuilderContext {
 
 pub struct PhysicalPlanBuilder {
     query_tools: Rc<QueryTools>,
-    _plan_sql_templates: PlanSqlTemplates,
+    plan_sql_templates: PlanSqlTemplates,
 }
 
 impl PhysicalPlanBuilder {
     pub fn new(query_tools: Rc<QueryTools>) -> Self {
         let plan_sql_templates = query_tools.plan_sql_templates();
         Self {
             query_tools,
-            _plan_sql_templates: plan_sql_templates,
+            plan_sql_templates,
         }
     }
 
@@ -464,17 +464,14 @@ impl PhysicalPlanBuilder {
             let on = JoinCondition::new_dimension_join(conditions, true);
             let next_alias = format!("q_{}", i);
 
-            join_builder.inner_join_source(join.clone(), next_alias, on);
-
-            /*      TODO: Full join fails even in BigQuery, where it’s theoretically supported. Disabled for now — needs investigation.
             if full_key_aggregate.use_full_join_and_coalesce
-                      && self.plan_sql_templates.supports_full_join()
-                  {
-                      join_builder.full_join_source(join.clone(), next_alias, on);
-                  } else {
-                      // TODO in case of full join is not supported there should be correct blending query that keeps NULL values
-                      join_builder.inner_join_source(join.clone(), next_alias, on);
-                  } */
+                && self.plan_sql_templates.supports_full_join()
+            {
+                join_builder.full_join_source(join.clone(), next_alias, on);
+            } else {
+                // TODO in case of full join is not supported there should be correct blending query that keeps NULL values
+                join_builder.inner_join_source(join.clone(), next_alias, on);
+            }
         }
 
         let result = From::new_from_join(join_builder.build());