a bit of types

Author: KSDaemon

packages/cubejs-query-orchestrator/src/orchestrator/BaseQueueEventsBus.ts

@@ -1,11 +1,11 @@
 export class BaseQueueEventsBus {
   protected readonly subscribers: Record<string, any> = {};
 
-  public subscribe(id, callback) {
+  public subscribe(id: string, callback) {
     this.subscribers[id] = { id, callback };
   }
 
-  public unsubscribe(id) {
+  public unsubscribe(id: string) {
     delete this.subscribers[id];
   }
 }

packages/cubejs-query-orchestrator/src/orchestrator/QueryOrchestrator.ts

@@ -448,11 +448,11 @@ export class QueryOrchestrator {
     return this.preAggregations.cancelQueriesFromQueue(queryKeys, dataSource);
   }
 
-  public async subscribeQueueEvents(id, callback) {
+  public async subscribeQueueEvents(id: string, callback) {
     return this.getQueueEventsBus().subscribe(id, callback);
   }
 
-  public async unSubscribeQueueEvents(id) {
+  public async unSubscribeQueueEvents(id: string) {
     return this.getQueueEventsBus().unsubscribe(id);
   }
 

packages/cubejs-server-core/src/core/OrchestratorApi.ts

@@ -174,7 +174,7 @@ export class OrchestratorApi {
   }
 
   /**
-   * Tests worker's connections to the Cubstore and, if not in the rollup only
+   * Tests worker's connections to the Cubestore and, if not in the rollup only
    * mode, to the datasources.
    */
   public async testConnection() {
@@ -274,11 +274,11 @@ export class OrchestratorApi {
     return this.orchestrator.cancelPreAggregationQueriesFromQueue(queryKeys, dataSource);
   }
 
-  public async subscribeQueueEvents(id, callback) {
+  public async subscribeQueueEvents(id: string, callback) {
     return this.orchestrator.subscribeQueueEvents(id, callback);
   }
 
-  public async unSubscribeQueueEvents(id) {
+  public async unSubscribeQueueEvents(id: string) {
     return this.orchestrator.unSubscribeQueueEvents(id);
   }