Skip to content

Commit c05d88d

Browse files
committed
remove incorrect :(
1 parent dcf4a43 commit c05d88d

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2241,13 +2241,6 @@ export class BaseQuery {
22412241
}
22422242
}
22432243

2244-
// This is a special recursion guard that might happen sometimes, like
2245-
// during alias members collection which invokes sql evaluation of all members
2246-
// when FILTER_PARAMS is proxied for SQL evaluation.
2247-
if (parentMember === memberPath) {
2248-
return '';
2249-
}
2250-
22512244
this.safeEvaluateSymbolContext().currentMember = memberPath;
22522245
try {
22532246
if (type === 'measure') {
@@ -3895,7 +3888,6 @@ export class BaseQuery {
38953888
// allBackAliasMembersExceptSegments() -> collectFrom() -> traverseSymbol() -> evaluateSymbolSql() ->
38963889
// autoPrefixAndEvaluateSql() -> evaluateSql() -> filterProxyFromAllFilters->Proxy->toString()
38973890
// and so on...
3898-
// For this case there is a recursion guard added to this.evaluateSymbolSql()
38993891
const aliases = allFilters ?
39003892
allFilters
39013893
.map(v => (v.query ? v.query.allBackAliasMembersExceptSegments() : {}))

0 commit comments

Comments
 (0)