fix(databricks-jdbc-driver): Return NULL decimal as NULL instead of 0 (#6768)

* fix(databricks-jdbc-driver): Return NULL decimal as NULL instead of 0

* Release node-jdbc

* Removing failing unload as it tested by other tests

* Fix reference to node-jdbc

* Bump oracle start timeout

* Bump oracle start timeout

* Fix broken YAML indexes

* Bump startPeriod for Oracle

* Try out log wait strategy for oracle

* Show oracle container logs

* Fix rust-cache working directory

* Try to run oracle first just in case

* Try to run oracle first just in case

* Try to run oracle first just in case

* Fix working-directory for rust-cache

* Fix working-directory for rust-cache

Author: paveltiunov

.github/actions/smoke.sh

@@ -4,16 +4,16 @@ set -eo pipefail
 # Debug log for test containers
 export DEBUG=testcontainers
 
+echo "::group::Oracle"
+yarn lerna run --concurrency 1 --stream --no-prefix smoke:oracle
+echo "::endgroup::"
+
 echo "::group::DuckDB"
 # Should we create a separate job integration-duckdb? I believe not, because it works fast.
 yarn lerna run --concurrency 1 --stream --no-prefix integration:duckdb
 yarn lerna run --concurrency 1 --stream --no-prefix smoke:duckdb
 echo "::endgroup::"
 
-echo "::group::Oracle"
-yarn lerna run --concurrency 1 --stream --no-prefix smoke:oracle
-echo "::endgroup::"
-
 echo "::group::Postgres"
 yarn lerna run --concurrency 1 --stream --no-prefix smoke:postgres
 echo "::endgroup::"

.github/workflows/push.yml

@@ -342,6 +342,7 @@ jobs:
       - uses: Swatinem/rust-cache@v1
         with:
           working-directory: ./rust/cubestore
+          shared-key: cubestore
           key: ubuntu-20.04
       - name: Build cubestore
         uses: actions-rs/cargo@v1
@@ -468,6 +469,7 @@ jobs:
       - uses: Swatinem/rust-cache@v1
         with:
           working-directory: ./rust/cubestore
+          shared-key: cubestore
           key: ubuntu-20.04
       - name: Build cubestore
         uses: actions-rs/cargo@v1

packages/cubejs-athena-driver/test/AthenaDriver.test.ts

@@ -44,10 +44,6 @@ describe('AthenaDriver', () => {
     await tests.testStream();
   });
 
-  test('unload', async () => {
-    await tests.testUnload();
-  });
-
   test('unload CSV escape symbol', async () => {
     await tests.testUnloadEscapeSymbolOp1(AthenaDriver);
     await tests.testUnloadEscapeSymbolOp2(AthenaDriver);

packages/cubejs-jdbc-driver/package.json

@@ -32,7 +32,7 @@
   },
   "optionalDependencies": {
     "java": "^0.12.1",
-    "jdbc": "^0.7.4"
+    "@cubejs-backend/jdbc": "^0.7.6"
   },
   "license": "Apache-2.0",
   "eslintConfig": {

packages/cubejs-jdbc-driver/src/JDBCDriver.ts

@@ -21,10 +21,10 @@ import { DriverOptionsInterface, SupportedDrivers } from './supported-drivers';
 import { JDBCDriverConfiguration } from './types';
 import { QueryStream, nextFn, Row } from './QueryStream';
 
-const DriverManager = require('jdbc/lib/drivermanager');
-const Connection = require('jdbc/lib/connection');
-const DatabaseMetaData = require('jdbc/lib/databasemetadata');
-const jinst = require('jdbc/lib/jinst');
+const DriverManager = require('@cubejs-backend/jdbc/lib/drivermanager');
+const Connection = require('@cubejs-backend/jdbc/lib/connection');
+const DatabaseMetaData = require('@cubejs-backend/jdbc/lib/databasemetadata');
+const jinst = require('@cubejs-backend/jdbc/lib/jinst');
 const mvn = require('node-java-maven');
 
 let mvnPromise: Promise<void> | null = null;

packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts

@@ -250,6 +250,8 @@ export class YamlCompiler {
       if (!name) {
         errorsReport.error(`name isn't defined for ${memberType}: ${YAML.stringify(rest)}`);
         return {};
+      } else if (indexes) {
+        return { [name]: { indexes, ...rest } };
       } else {
         return { [name]: rest };
       }

packages/cubejs-testing-drivers/fixtures/athena.json

@@ -98,6 +98,7 @@
     "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- rounding in athena",
     "querying ECommerce: total sales, total profit by month + order (date) + total -- doesn't work with the BigQuery",
     "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- noisy test",
-    "querying BigECommerce: partitioned pre-agg"
+    "querying BigECommerce: partitioned pre-agg",
+    "querying BigECommerce: null sum"
   ]
 }

packages/cubejs-testing-drivers/fixtures/bigquery.json

@@ -114,6 +114,7 @@
     "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- noisy test",
     "querying ECommerce: partitioned pre-agg",
     "querying ECommerce: partitioned pre-agg higher granularity",
-    "querying BigECommerce: partitioned pre-agg"
+    "querying BigECommerce: partitioned pre-agg",
+    "querying BigECommerce: null sum"
   ]
 }

packages/cubejs-testing-drivers/fixtures/clickhouse.json

@@ -117,6 +117,7 @@
     "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- noisy test",
     "querying ECommerce: partitioned pre-agg",
     "querying ECommerce: partitioned pre-agg higher granularity",
-    "querying BigECommerce: partitioned pre-agg"
+    "querying BigECommerce: partitioned pre-agg",
+    "querying BigECommerce: null sum"
   ]
 }

packages/cubejs-testing-drivers/fixtures/mssql.json

@@ -106,6 +106,7 @@
     "querying Products: dimensions -- doesn't work wo ordering",
     "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- rounding in athena",
     "querying ECommerce: total sales, total profit by month + order (date) + total -- doesn't work with the BigQuery",
-    "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- noisy test"
+    "querying ECommerce: total quantity, avg discount, total sales, total profit by product + order + total -- noisy test",
+    "querying BigECommerce: null sum"
   ]
 }