Skip to content

Commit c39c598

Browse files
committed
more types in BaseQuery
1 parent 9f93140 commit c39c598

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,11 @@ export class BaseQuery {
130130
/** @type {import('./BaseTimeDimension').BaseTimeDimension[]} */
131131
timeDimensions;
132132

133+
/**
134+
* @type {import('../compiler/JoinGraph').FinishedJoinTree}
135+
*/
136+
join;
137+
133138
/**
134139
* BaseQuery class constructor.
135140
* @param {Compilers|*} compilers
@@ -2194,6 +2199,11 @@ export class BaseQuery {
21942199
}
21952200
}
21962201

2202+
/**
2203+
* @param {import('../compiler/JoinGraph').FinishedJoinTree} join
2204+
* @param {Array<string>} subQueryDimensions
2205+
* @returns {string}
2206+
*/
21972207
joinQuery(join, subQueryDimensions) {
21982208
const subQueryDimensionsByCube = R.groupBy(d => this.cubeEvaluator.cubeNameFromPath(d), subQueryDimensions);
21992209
const joins = join.joins.flatMap(
@@ -2218,6 +2228,10 @@ export class BaseQuery {
22182228
]);
22192229
}
22202230

2231+
/**
2232+
* @param {JoinChain} toJoin
2233+
* @returns {string}
2234+
*/
22212235
joinSql(toJoin) {
22222236
const [root, ...rest] = toJoin;
22232237
const joins = rest.map(

0 commit comments

Comments
 (0)