code polish

Author: KSDaemon

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

@@ -429,7 +429,7 @@ export class BaseQuery {
       // join path will be constructed in join graph.
       // It is important to use queryLevelJoinHints during the calculation if it is set.
 
-      const constructJP = () => {
+      const constructJH = () => {
         const filteredJoinMembersJoinHints = joinMembersJoinHints.filter(m => !allMembersJoinHints.includes(m));
         return [
           ...this.queryLevelJoinHints,
@@ -441,15 +441,15 @@ export class BaseQuery {
       };
 
       let prevJoins = this.join;
-      let newJoin = this.joinGraph.buildJoin(constructJP());
+      let newJoin = this.joinGraph.buildJoin(constructJH());
 
       while (newJoin?.joins.length > 0 && !R.equals(prevJoins, newJoin)) {
         prevJoins = newJoin;
         joinMembersJoinHints = this.collectJoinHintsFromMembers(this.joinMembersFromJoin(newJoin));
-        newJoin = this.joinGraph.buildJoin(constructJP());
+        newJoin = this.joinGraph.buildJoin(constructJH());
       }
 
-      this.collectedJoinHints = R.uniq(constructJP());
+      this.collectedJoinHints = R.uniq(constructJH());
     }
     return this.collectedJoinHints;
   }

packages/cubejs-schema-compiler/test/integration/postgres/cube-views.test.ts

@@ -6,6 +6,7 @@ import { dbRunner } from './PostgresDBRunner';
 describe('Cube Views', () => {
   jest.setTimeout(200000);
 
+  // language=JavaScript
   const { compiler, joinGraph, cubeEvaluator, metaTransformer } = prepareJsCompiler(`
 cube(\`Orders\`, {
   sql: \`

packages/cubejs-schema-compiler/test/integration/postgres/sql-generation.test.ts

@@ -11,6 +11,7 @@ import { testWithPreAggregation } from './pre-aggregation-utils';
 describe('SQL Generation', () => {
   jest.setTimeout(200000);
 
+  // language=JavaScript
   const { compiler, joinGraph, cubeEvaluator } = prepareJsCompiler(`
     const perVisitorRevenueMeasure = {
       type: 'number',
@@ -4054,7 +4055,9 @@ SELECT 1 AS revenue,  cast('2024-01-01' AS timestamp) as time UNION ALL
 
   describe('Transitive join paths', () => {
     // eslint-disable-next-line @typescript-eslint/no-shadow
-    const { compiler, joinGraph, cubeEvaluator } = prepareYamlCompiler(`
+    const { compiler, joinGraph, cubeEvaluator } =
+      // language=yaml
+      prepareYamlCompiler(`
 cubes:
   - name: merchant_dims
     sql: |