Skip to content

Commit c518a34

Browse files
committed
pass cache_mode from SqlApiLoadPayload
1 parent dcd7912 commit c518a34

File tree

5 files changed

+15
-14
lines changed

5 files changed

+15
-14
lines changed

packages/cubejs-api-gateway/src/sql-server.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,9 @@ export class SQLServer {
207207
}
208208
});
209209
},
210-
sqlApiLoad: async ({ request, session, query, queryKey, sqlQuery, streaming }) => {
210+
sqlApiLoad: async ({ request, session, query, queryKey, sqlQuery, streaming, cacheMode }) => {
211211
const context = await contextByRequest(request, session);
212212

213-
// XXX: Should we pass cacheMode somehow?
214-
215213
// eslint-disable-next-line no-async-promise-executor
216214
return new Promise(async (resolve, reject) => {
217215
try {
@@ -220,6 +218,7 @@ export class SQLServer {
220218
query,
221219
sqlQuery,
222220
streaming,
221+
cacheMode,
223222
context,
224223
memberExpressions: true,
225224
res: (response) => {

packages/cubejs-backend-native/js/index.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,13 @@ export interface SqlPayload {
7878
}
7979

8080
export interface SqlApiLoadPayload {
81-
request: Request<LoadRequestMeta>,
82-
session: SessionContext,
83-
query: any,
84-
queryKey: any,
85-
sqlQuery: any,
86-
streaming: boolean,
81+
request: Request<LoadRequestMeta>;
82+
session: SessionContext;
83+
query: any;
84+
queryKey: any;
85+
sqlQuery: any;
86+
streaming: boolean;
87+
cacheMode: CacheMode;
8788
}
8889

8990
export interface LogLoadEventPayload {

packages/cubejs-backend-native/src/transport.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ use crate::{
1212
stream::call_js_with_stream_as_callback,
1313
};
1414
use async_trait::async_trait;
15-
use cubesql::compile::engine::df::scan::{
16-
convert_transport_response, transform_response, MemberField, RecordBatch, SchemaRef,
17-
};
15+
use cubesql::compile::engine::df::scan::{convert_transport_response, transform_response, CacheMode, MemberField, RecordBatch, SchemaRef};
1816
use cubesql::compile::engine::df::wrapper::SqlQuery;
1917
use cubesql::transport::{
2018
SpanId, SqlGenerator, SqlResponse, TransportLoadRequestQuery, TransportLoadResponse,
@@ -91,6 +89,8 @@ struct LoadRequest {
9189
streaming: bool,
9290
#[serde(rename = "queryKey", skip_serializing_if = "Option::is_none")]
9391
query_key: Option<serde_json::Value>,
92+
#[serde(rename = "cacheMode", skip_serializing_if = "Option::is_none")]
93+
cache_mode: Option<CacheMode>,
9494
}
9595

9696
#[derive(Debug, Serialize)]
@@ -338,6 +338,7 @@ impl TransportService for NodeBridgeTransport {
338338
meta: LoadRequestMeta,
339339
schema: SchemaRef,
340340
member_fields: Vec<MemberField>,
341+
cache_mode: Option<CacheMode>,
341342
) -> Result<Vec<RecordBatch>, CubeError> {
342343
trace!("[transport] Request ->");
343344

@@ -371,6 +372,7 @@ impl TransportService for NodeBridgeTransport {
371372
member_to_alias: None,
372373
expression_params: None,
373374
streaming: false,
375+
cache_mode,
374376
})?;
375377

376378
let result = call_raw_js_with_channel_as_callback(

packages/cubejs-server-core/src/core/OrchestratorApi.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import {
1111
} from '@cubejs-backend/query-orchestrator';
1212

1313
import { DatabaseType, RequestContext } from './types';
14-
import { CacheMode } from '@cubejs-backend/shared';
1514

1615
export interface OrchestratorApiOptions extends QueryOrchestratorOptions {
1716
contextToDbType: (dataSource: string) => Promise<DatabaseType>;

rust/cubesql/cubesql/src/compile/engine/df/scan.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ impl MemberField {
7979
}
8080
}
8181

82-
#[derive(Debug, Clone)]
82+
#[derive(Debug, Clone, Serialize)]
8383
pub enum CacheMode {
8484
StaleIfSlow,
8585
StaleWhileRevalidate,

0 commit comments

Comments
 (0)