some optimizations and improvements

Author: KSDaemon

packages/cubejs-backend-native/src/node_export.rs

@@ -511,14 +511,14 @@ fn debug_js_to_clrepr_to_js(mut cx: FunctionContext) -> JsResult<JsValue> {
 fn parse_cubestore_ws_result_message(mut cx: FunctionContext) -> JsResult<JsValue> {
     let msg = cx.argument::<JsBuffer>(0)?;
     let msg_data = msg.as_slice(&cx);
-    match parse_cubestore_ws_result(msg_data.to_vec()) {
+    match parse_cubestore_ws_result(msg_data) {
         Ok(result) => {
             let js_array = JsArray::new(&mut cx, result.len());
             for (i, row) in result.into_iter().enumerate() {
                 let js_row = JsObject::new(&mut cx);
-                for (key, value) in row {
-                    let js_key = cx.string(key);
-                    let js_value = cx.string(value);
+                for (key, value) in row.into_iter() {
+                    let js_key = cx.string(&key);
+                    let js_value = cx.string(&value);
                     js_row.set(&mut cx, js_key, js_value)?;
                 }
                 js_array.set(&mut cx, i as u32, js_row)?;

rust/cubeorchestrator/rustfmt.toml

@@ -1 +1 @@
-imports_granularity = "Crate"
+imports_granularity = "Crate"

rust/cubeorchestrator/src/cubestore_message_parser.rs

@@ -29,10 +29,10 @@ impl std::fmt::Display for ParseError {
 impl std::error::Error for ParseError {}
 
 pub fn parse_cubestore_ws_result(
-    msg_data: Vec<u8>,
+    msg_data: &[u8],
 ) -> Result<Vec<HashMap<String, String>>, ParseError> {
     let http_message =
-        root_as_http_message(msg_data.as_slice()).map_err(|_| ParseError::FlatBufferError)?;
+        root_as_http_message(msg_data).map_err(|_| ParseError::FlatBufferError)?;
 
     let command_type = http_message.command_type();