Skip to content

Commit c718563

Browse files
committed
chore(cubestore): Upgrade DF: Return correct EmissionType values in Cube ExecutionPlans
1 parent 0f533a5 commit c718563

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

rust/cubestore/cubestore/src/queryplanner/panic.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ impl PanicWorkerExec {
122122
properties: PlanProperties::new(
123123
EquivalenceProperties::new(Arc::new(Schema::empty())),
124124
Partitioning::UnknownPartitioning(1),
125-
EmissionType::Both, // Well, neither.
125+
EmissionType::Incremental, // Not really applicable.
126126
Boundedness::Bounded,
127127
),
128128
}

rust/cubestore/cubestore/src/queryplanner/providers/query_cache.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ impl TableProvider for InfoSchemaQueryCacheTableProvider {
7070
properties: PlanProperties::new(
7171
EquivalenceProperties::new(schema),
7272
Partitioning::UnknownPartitioning(1),
73-
EmissionType::Both, // TODO upgrade DF: which?
73+
EmissionType::Final,
7474
Boundedness::Bounded,
7575
),
7676
};

rust/cubestore/cubestore/src/queryplanner/query_executor.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1052,11 +1052,6 @@ impl ExecutionPlan for CubeTableExec {
10521052
self.schema.clone()
10531053
}
10541054

1055-
// TODO upgrade DF
1056-
// fn output_partitioning(&self) -> Partitioning {
1057-
// Partitioning::UnknownPartitioning(self.partition_execs.len())
1058-
// }
1059-
10601055
fn children(&self) -> Vec<&Arc<dyn ExecutionPlan>> {
10611056
self.partition_execs.iter().collect()
10621057
}
@@ -1347,7 +1342,7 @@ impl ClusterSendExec {
13471342
PlanProperties::new(
13481343
eq_properties,
13491344
Partitioning::UnknownPartitioning(partitions_num),
1350-
EmissionType::Both, // Or Final, but we should implement streaming.
1345+
EmissionType::Final, // We should implement streaming.
13511346
input_properties.boundedness.clone(),
13521347
)
13531348
}

rust/cubestore/cubestore/src/queryplanner/topk/execute.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ impl AggregateTopKExec {
8484
let cache = PlanProperties::new(
8585
EquivalenceProperties::new(schema.clone()),
8686
Partitioning::UnknownPartitioning(1),
87-
EmissionType::Both, // TODO upgrade DF
87+
EmissionType::Final,
8888
Boundedness::Bounded,
8989
);
9090

0 commit comments

Comments
 (0)