chore: warnings

Author: ovr

rust/cubeshared/src/codegen/mod.rs

@@ -1,4 +1,5 @@
 #[allow(unused_imports)]
+#[allow(mismatched_lifetime_syntaxes)]
 mod http_message_generated;
 
 pub use http_message_generated::*;

rust/cubestore/cubehll/src/instance.rs

@@ -1217,7 +1217,7 @@ struct BitCursor<'a> {
 }
 
 impl BitCursor<'_> {
-    pub fn new(input: &[u8]) -> BitCursor {
+    pub fn new(input: &[u8]) -> BitCursor<'_> {
         BitCursor {
             input,
             pos: 0,

rust/cubestore/cubestore/src/cachestore/lazy.rs

@@ -24,7 +24,7 @@ pub enum LazyRocksCacheStoreState {
         metastore_fs: Arc<dyn MetaStoreFs>,
         config: Arc<dyn ConfigObj>,
         listeners: Vec<tokio::sync::broadcast::Sender<MetaStoreEvent>>,
-        init_flag: Sender<bool>,
+        _init_flag: Sender<bool>,
     },
     Closed {},
     Initialized {
@@ -72,7 +72,7 @@ impl LazyRocksCacheStore {
                 metastore_fs,
                 config,
                 listeners,
-                init_flag,
+                _init_flag: init_flag,
             }),
         }))
     }
@@ -101,7 +101,7 @@ impl LazyRocksCacheStore {
                 config,
                 listeners,
                 // receiver will be closed on drop
-                init_flag: _,
+                _init_flag: _,
             } => {
                 let store =
                     RocksCacheStore::load_from_remote(&path, metastore_fs.clone(), config.clone())

rust/cubestore/cubestore/src/cachestore/queue_item_payload.rs

@@ -42,6 +42,7 @@ impl QueueItemPayload {
 }
 
 #[derive(Clone, Copy, Debug)]
+#[allow(dead_code)]
 pub(crate) enum QueueItemPayloadRocksIndex {}
 
 pub struct QueueItemPayloadRocksTable<'a> {
@@ -80,6 +81,7 @@ rocks_table_new!(
 );
 
 #[derive(Hash, Clone, Debug)]
+#[allow(dead_code)]
 pub enum QueueItemPayloadIndexKey {}
 
 base_rocks_secondary_index!(QueueItemPayload, QueueItemPayloadRocksIndex);

rust/cubestore/cubestore/src/import/mod.rs

@@ -323,7 +323,7 @@ impl<'a> CsvLineParser<'a> {
         }
     }
 
-    fn next_value(&mut self) -> Result<MaybeOwnedStr, CubeError> {
+    fn next_value(&mut self) -> Result<MaybeOwnedStr<'_>, CubeError> {
         Ok(
             if let Some(b'"') = self.remaining.as_bytes().iter().nth(0) {
                 let mut closing_index = None;

rust/cubestore/cubestore/src/metastore/rocks_table.rs

@@ -61,15 +61,15 @@ macro_rules! rocks_table_new {
                 self.db.db
             }
 
-            fn snapshot(&self) -> &cuberockstore::rocksdb::Snapshot {
+            fn snapshot(&self) -> &cuberockstore::rocksdb::Snapshot<'_> {
                 self.db.snapshot
             }
 
             fn mem_seq(&self) -> &crate::metastore::MemorySequence {
                 &self.db.mem_seq
             }
 
-            fn table_ref(&self) -> &crate::metastore::DbTableRef {
+            fn table_ref(&self) -> &crate::metastore::DbTableRef<'_> {
                 &self.db
             }
 
@@ -448,8 +448,8 @@ pub trait RocksTable: BaseRocksTable + Debug + Send + Sync {
     fn delete_event(&self, row: IdRow<Self::T>) -> MetaStoreEvent;
     fn update_event(&self, old_row: IdRow<Self::T>, new_row: IdRow<Self::T>) -> MetaStoreEvent;
     fn db(&self) -> &DB;
-    fn table_ref(&self) -> &DbTableRef;
-    fn snapshot(&self) -> &Snapshot;
+    fn table_ref(&self) -> &DbTableRef<'_>;
+    fn snapshot(&self) -> &Snapshot<'_>;
     fn mem_seq(&self) -> &MemorySequence;
     fn index_id(index_num: IndexId) -> IndexId;
     fn table_id() -> TableId;

rust/cubestore/cubestore/src/queryplanner/topk/plan.rs

@@ -207,7 +207,7 @@ fn extract_having(p: &Arc<LogicalPlan>) -> (Option<Expr>, &Arc<LogicalPlan>) {
     }
 }
 
-fn extract_projection_and_having(p: &LogicalPlan) -> Option<ColumnProjection> {
+fn extract_projection_and_having(p: &LogicalPlan) -> Option<ColumnProjection<'_>> {
     match p {
         LogicalPlan::Projection {
             expr,

rust/cubestore/cubestore/src/remotefs/mod.rs

@@ -91,7 +91,7 @@ pub trait ExtendedRemoteFs: DIService + RemoteFs {
     async fn list_by_page(
         &self,
         remote_prefix: String,
-    ) -> Result<BoxStream<Result<Vec<String>, CubeError>>, CubeError> {
+    ) -> Result<BoxStream<'_, Result<Vec<String>, CubeError>>, CubeError> {
         // Note, this implementation doesn't actually paginate.
         let list: Vec<String> = self.list(remote_prefix).await?;
 

rust/cubestore/cubestore/src/remotefs/queue.rs

@@ -346,7 +346,7 @@ impl ExtendedRemoteFs for QueueRemoteFs {
     async fn list_by_page(
         &self,
         remote_prefix: String,
-    ) -> Result<BoxStream<Result<Vec<String>, CubeError>>, CubeError> {
+    ) -> Result<BoxStream<'_, Result<Vec<String>, CubeError>>, CubeError> {
         self.remote_fs.list_by_page(remote_prefix).await
     }
 }

rust/cubestore/cubestore/src/remotefs/s3.rs

@@ -346,7 +346,7 @@ impl ExtendedRemoteFs for S3RemoteFs {
     async fn list_by_page(
         &self,
         remote_prefix: String,
-    ) -> Result<BoxStream<Result<Vec<String>, CubeError>>, CubeError> {
+    ) -> Result<BoxStream<'_, Result<Vec<String>, CubeError>>, CubeError> {
         let path = self.s3_path(&remote_prefix);
         let bucket = self.bucket.load();
         let leading_subpath = self.leading_subpath_regex();