Skip to content

Commit cad6918

Browse files
committed
fix(cubesql): Allow to push LIMIT 0 to CubeScan
1 parent ba4a242 commit cad6918

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

rust/cubesql/cubesql/src/compile/rewrite/rules/members.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1621,17 +1621,13 @@ impl MemberRules {
16211621

16221622
let mut skip_value = None;
16231623
for skip in var_iter!(egraph[subst[skip_var]], LimitSkip) {
1624-
if skip.unwrap_or_default() > 0 {
1625-
skip_value = *skip;
1626-
break;
1627-
}
1624+
skip_value = *skip;
1625+
break;
16281626
}
16291627
let mut fetch_value = None;
16301628
for fetch in var_iter!(egraph[subst[fetch_var]], LimitFetch) {
1631-
if fetch.unwrap_or_default() > 0 {
1632-
fetch_value = *fetch;
1633-
break;
1634-
}
1629+
fetch_value = *fetch;
1630+
break;
16351631
}
16361632

16371633
let mut inner_skip_value = None;

rust/cubesql/cubesql/src/compile/test/test_wrapper.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1234,7 +1234,7 @@ async fn select_agg_where_false() {
12341234
segments: Some(vec![]),
12351235
dimensions: Some(vec![]),
12361236
order: Some(vec![]),
1237-
limit: None,
1237+
limit: Some(0),
12381238
ungrouped: Some(true),
12391239
..Default::default()
12401240
}

0 commit comments

Comments
 (0)