Skip to content

Commit cc97085

Browse files
committed
chore(cubestore): Upgrade DF: Return finer EmissionType values
1 parent e6d2ebd commit cc97085

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

rust/cubestore/cubestore/src/queryplanner/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -756,7 +756,7 @@ impl TableProvider for InfoSchemaTableProvider {
756756
properties: PlanProperties::new(
757757
EquivalenceProperties::new(schema),
758758
Partitioning::UnknownPartitioning(1),
759-
EmissionType::Both, // TODO upgrade DF: Both is safe choice
759+
EmissionType::Final,
760760
Boundedness::Bounded,
761761
),
762762
};

rust/cubestore/cubestore/src/queryplanner/query_executor.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -894,7 +894,7 @@ impl CubeTable {
894894
)?)],
895895
),
896896
Partitioning::UnknownPartitioning(partition_num),
897-
EmissionType::Both, // TODO upgrade DF
897+
EmissionType::Incremental,
898898
Boundedness::Bounded,
899899
),
900900
});
@@ -1084,7 +1084,7 @@ impl ExecutionPlan for CubeTableExec {
10841084
)?)],
10851085
),
10861086
Partitioning::UnknownPartitioning(partition_count),
1087-
EmissionType::Both, // TODO upgrade DF
1087+
EmissionType::Incremental,
10881088
Boundedness::Bounded,
10891089
),
10901090
}))
@@ -1348,7 +1348,7 @@ impl ClusterSendExec {
13481348
PlanProperties::new(
13491349
eq_properties,
13501350
Partitioning::UnknownPartitioning(partitions_num),
1351-
EmissionType::Both, // TODO upgrade DF: Actually Final, unless we implement streaming, but check if that value has implications.
1351+
EmissionType::Both, // Or Final, but we should implement streaming.
13521352
input_properties.boundedness.clone(),
13531353
)
13541354
}

rust/cubestore/cubestore/src/queryplanner/rolling.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ impl ExtensionPlanner for RollingWindowPlanner {
590590
// EquivalenceProperties::new_with_orderings(schema.clone().into(), &[sort_key]),
591591
EquivalenceProperties::new(schema.clone().into()),
592592
Partitioning::UnknownPartitioning(1),
593-
EmissionType::Both, // TODO upgrade DF
593+
EmissionType::Final,
594594
Boundedness::Bounded,
595595
),
596596
sorted_input: sort,

0 commit comments

Comments
 (0)