chore(cubestore): DF upgrade: Disable ident normalization, remove lowercase normalization in some lookups

This is to get ourselves back in line with old pre-DF-upgrade
behavior.  Maybe, instead, we should force Cube to quote literals in
its queries, but suppose we did that: We're working with generated
queries.  Normalization to lowercase would mean that any unquoted
identifiers that have uppercase characters would be a certain bug.

This avoids one factor that would require Cube changes and a Cube
upgrade in order to use the Cube.

Author: srh

rust/cubestore/cubestore-sql-tests/src/tests.rs

@@ -7689,10 +7689,10 @@ async fn inline_tables(service: Box<dyn SqlClient>) {
     );
 
     let columns = vec![
-        Column::new("id".to_string(), ColumnType::Int, 0),
-        Column::new("lastname".to_string(), ColumnType::String, 1),
-        Column::new("firstname".to_string(), ColumnType::String, 2),
-        Column::new("timestamp".to_string(), ColumnType::Timestamp, 3),
+        Column::new("ID".to_string(), ColumnType::Int, 0),
+        Column::new("LastName".to_string(), ColumnType::String, 1),
+        Column::new("FirstName".to_string(), ColumnType::String, 2),
+        Column::new("Timestamp".to_string(), ColumnType::Timestamp, 3),
     ];
     let rows = vec![
         Row::new(vec![
@@ -7721,7 +7721,7 @@ async fn inline_tables(service: Box<dyn SqlClient>) {
         ]),
     ];
     let data = Arc::new(DataFrame::new(columns, rows.clone()));
-    let inline_tables = vec![InlineTable::new(1000, "persons".to_string(), data)];
+    let inline_tables = vec![InlineTable::new(1000, "Persons".to_string(), data)];
 
     let context = SqlQueryContext::default().with_inline_tables(&inline_tables);
     let result = service
@@ -7830,9 +7830,9 @@ async fn inline_tables_2x(service: Box<dyn SqlClient>) {
         .unwrap();
 
     let columns = vec![
-        Column::new("id".to_string(), ColumnType::Int, 0),
-        Column::new("last".to_string(), ColumnType::String, 1),
-        Column::new("first".to_string(), ColumnType::String, 2),
+        Column::new("ID".to_string(), ColumnType::Int, 0),
+        Column::new("Last".to_string(), ColumnType::String, 1),
+        Column::new("First".to_string(), ColumnType::String, 2),
     ];
     let rows = vec![
         Row::new(vec![
@@ -7871,8 +7871,8 @@ async fn inline_tables_2x(service: Box<dyn SqlClient>) {
     let data = Arc::new(DataFrame::new(columns.clone(), rows.clone()));
     let data2 = Arc::new(DataFrame::new(columns.clone(), rows2.clone()));
     let inline_tables = vec![
-        InlineTable::new(1000, "persons".to_string(), data),
-        InlineTable::new(1001, "persons2".to_string(), data2),
+        InlineTable::new(1000, "Persons".to_string(), data),
+        InlineTable::new(1001, "Persons2".to_string(), data2),
     ];
 
     let context = SqlQueryContext::default().with_inline_tables(&inline_tables);

rust/cubestore/cubestore/src/queryplanner/mod.rs

@@ -153,7 +153,7 @@ impl QueryPlanner for QueryPlannerImpl {
             state.clone(),
         );
 
-        let query_planner = SqlToRel::new(&schema_provider);
+        let query_planner = SqlToRel::new_with_options(&schema_provider, sql_to_rel_options());
         let mut logical_plan = query_planner.statement_to_plan(statement)?;
 
         // TODO upgrade DF remove
@@ -349,7 +349,7 @@ impl ContextProvider for MetaStoreSchemaProvider {
                 let table = self
                     .inline_tables
                     .iter()
-                    .find(|inline_table| inline_table.name.to_lowercase() == table.as_ref())
+                    .find(|inline_table| inline_table.name == table.as_ref())
                     .ok_or_else(|| {
                         DataFusionError::Plan(format!("Inline table {} was not found", name))
                     })?;
@@ -574,6 +574,17 @@ impl ContextProvider for MetaStoreSchemaProvider {
     }
 }
 
+/// Enables our options used with `SqlToRel`.  Sets `enable_ident_normalization` to false.  See also
+/// `normalize_for_column_name` and its doc-comment, and similar functions, which must be kept in
+/// sync with changes to the `enable_ident_normalization` option set here.
+pub fn sql_to_rel_options() -> datafusion::sql::planner::ParserOptions {
+    // not to be confused with sql_parser's ParserOptions
+    datafusion::sql::planner::ParserOptions {
+        enable_ident_normalization: false,
+        ..Default::default()
+    }
+}
+
 #[derive(Clone, Debug)]
 pub enum InfoSchemaTable {
     Columns,
@@ -959,7 +970,7 @@ pub mod tests {
             other => panic!("not a statement, actual {:?}", other),
         };
 
-        let plan = SqlToRel::new(&ctx)
+        let plan = SqlToRel::new_with_options(&ctx, sql_to_rel_options())
             .statement_to_plan(DFStatement::Statement(Box::new(statement)))
             .unwrap();
         SessionContext::new().state().optimize(&plan).unwrap()

rust/cubestore/cubestore/src/queryplanner/partition_filter.rs

@@ -575,6 +575,7 @@ impl Builder<'_> {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::queryplanner::sql_to_rel_options;
     use crate::sql::parser::{CubeStoreParser, Statement as CubeStatement};
     use datafusion::arrow::datatypes::Field;
     use datafusion::common::{TableReference, ToDFSchema};
@@ -1472,9 +1473,9 @@ mod tests {
             _ => panic!("unexpected parse result"),
         }
 
-        SqlToRel::new(&NoContextProvider {
+        SqlToRel::new_with_options(&NoContextProvider {
             config_options: ConfigOptions::new(),
-        })
+        }, sql_to_rel_options())
         .sql_to_expr(
             sql_expr,
             &schema.clone().to_dfschema().unwrap(),