Skip to content

Commit d5959f3

Browse files
committed
WIP: Address todo about the Filter "having" field
1 parent 8295069 commit d5959f3

File tree

1 file changed

+3
-1
lines changed
  • rust/cubestore/cubestore/src/queryplanner/topk

1 file changed

+3
-1
lines changed

rust/cubestore/cubestore/src/queryplanner/topk/plan.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,9 @@ struct ColumnProjection<'a> {
246246
}
247247

248248
fn extract_having(p: &Arc<LogicalPlan>) -> (Option<Expr>, &Arc<LogicalPlan>) {
249-
// TODO upgrade DF: Filter now has a "having" clause.
249+
// Filter's "having" flag is not relevant to us. It is used by DF to get the proper wildcard
250+
// expansion behavior in the analysis pass (before LogicalPlan optimizations, and before we
251+
// materialize the topk node here).
250252
match p.as_ref() {
251253
LogicalPlan::Filter(Filter { predicate, input, having: _, .. }) => (Some(predicate.clone()), input),
252254
_ => (None, p),

0 commit comments

Comments
 (0)