fix dateBin implementation across all Queries (timeStampCast → dateTimeCast)

Author: KSDaemon

packages/cubejs-databricks-jdbc-driver/src/DatabricksQuery.ts

@@ -96,9 +96,9 @@ export class DatabricksQuery extends BaseQuery {
     const [intervalFormatted, timeUnit] = this.formatInterval(interval);
     const beginOfTime = this.dateTimeCast('\'1970-01-01T00:00:00\'');
 
-    return `${this.timeStampCast(`'${origin}'`)} + INTERVAL ${intervalFormatted} *
+    return `${this.dateTimeCast(`'${origin}'`)} + INTERVAL ${intervalFormatted} *
       floor(
-        date_diff(${timeUnit}, ${this.timeStampCast(`'${origin}'`)}, ${source}) /
+        date_diff(${timeUnit}, ${this.dateTimeCast(`'${origin}'`)}, ${source}) /
         date_diff(${timeUnit}, ${beginOfTime}, ${beginOfTime} + INTERVAL ${intervalFormatted})
       )`;
   }

packages/cubejs-duckdb-driver/src/DuckDBQuery.ts

@@ -35,11 +35,11 @@ export class DuckDBQuery extends BaseQuery {
    */
   public dateBin(interval: string, source: string, origin: string): string {
     const timeUnit = this.diffTimeUnitForInterval(interval);
-    const beginOfTime = this.timeStampCast('\'1970-01-01 00:00:00.000\'');
+    const beginOfTime = this.dateTimeCast('\'1970-01-01 00:00:00.000\'');
 
-    return `${this.timeStampCast(`'${origin}'`)}' + INTERVAL '${interval}' *
+    return `${this.dateTimeCast(`'${origin}'`)}' + INTERVAL '${interval}' *
       floor(
-        date_diff('${timeUnit}', ${this.timeStampCast(`'${origin}'`)}, ${source}) /
+        date_diff('${timeUnit}', ${this.dateTimeCast(`'${origin}'`)}, ${source}) /
         date_diff('${timeUnit}', ${beginOfTime}, ${beginOfTime} + INTERVAL '${interval}')
       )::int`;
   }

packages/cubejs-schema-compiler/src/adapter/ClickHouseQuery.ts

@@ -73,10 +73,10 @@ export class ClickHouseQuery extends BaseQuery {
 
     return `date_add(${timeUnit},
         FLOOR(
-          date_diff(${timeUnit}, ${this.timeStampCast(`'${origin}'`)}, ${source}) /
+          date_diff(${timeUnit}, ${this.dateTimeCast(`'${origin}'`)}, ${source}) /
           date_diff(${timeUnit}, ${beginOfTime}, ${beginOfTime} + ${intervalFormatted})
         ) * date_diff(${timeUnit}, ${beginOfTime}, ${beginOfTime} + ${intervalFormatted}),
-        ${this.timeStampCast(`'${origin}'`)}
+        ${this.dateTimeCast(`'${origin}'`)}
     )`;
   }
 

packages/cubejs-schema-compiler/src/adapter/CubeStoreQuery.ts

@@ -71,7 +71,7 @@ export class CubeStoreQuery extends BaseQuery {
    * intervals relative to origin timestamp point.
    */
   public dateBin(interval: string, source: string, origin: string): string {
-    return `DATE_BIN(INTERVAL ${this.formatInterval(interval)}, ${this.timeStampCast(source)}, ${this.timeStampCast(`'${origin}'`)})`;
+    return `DATE_BIN(INTERVAL ${this.formatInterval(interval)}, ${this.dateTimeCast(source)}, ${this.dateTimeCast(`'${origin}'`)})`;
   }
 
   /**

packages/cubejs-schema-compiler/src/adapter/MssqlQuery.ts

@@ -88,16 +88,16 @@ export class MssqlQuery extends BaseQuery {
    * The formula operates with seconds diffs so it won't produce human-expected dates aligned with offset date parts.
    */
   public dateBin(interval: string, source: string, origin: string): string {
-    const beginOfTime = this.timeStampCast('DATEFROMPARTS(1970, 1, 1)');
+    const beginOfTime = this.dateTimeCast('DATEFROMPARTS(1970, 1, 1)');
     const timeUnit = this.diffTimeUnitForInterval(interval);
 
     // Need to explicitly cast one argument of floor to float to trigger correct sign logic
     return `DATEADD(${timeUnit},
         FLOOR(
-          CAST(DATEDIFF(${timeUnit}, ${this.timeStampCast(`'${origin}'`)}, ${source}) AS FLOAT) /
+          CAST(DATEDIFF(${timeUnit}, ${this.dateTimeCast(`'${origin}'`)}, ${source}) AS FLOAT) /
           DATEDIFF(${timeUnit}, ${beginOfTime}, ${this.addInterval(beginOfTime, interval)})
         ) * DATEDIFF(${timeUnit}, ${beginOfTime}, ${this.addInterval(beginOfTime, interval)}),
-        ${this.timeStampCast(`'${origin}'`)}
+        ${this.dateTimeCast(`'${origin}'`)}
     )`;
   }
 

packages/cubejs-schema-compiler/src/adapter/MysqlQuery.ts

@@ -72,10 +72,10 @@ export class MysqlQuery extends BaseQuery {
 
     return `TIMESTAMPADD(${timeUnit},
         FLOOR(
-          TIMESTAMPDIFF(${timeUnit}, ${this.timeStampCast(`'${origin}'`)}, ${source}) /
+          TIMESTAMPDIFF(${timeUnit}, ${this.dateTimeCast(`'${origin}'`)}, ${source}) /
           TIMESTAMPDIFF(${timeUnit}, '1970-01-01 00:00:00', '1970-01-01 00:00:00' + INTERVAL ${intervalFormatted})
         ) * TIMESTAMPDIFF(${timeUnit}, '1970-01-01 00:00:00', '1970-01-01 00:00:00' + INTERVAL ${intervalFormatted}),
-        ${this.timeStampCast(`'${origin}'`)}
+        ${this.dateTimeCast(`'${origin}'`)}
     )`;
   }
 

packages/cubejs-schema-compiler/src/adapter/OracleQuery.ts

@@ -19,7 +19,7 @@ class OracleFilter extends BaseFilter {
   }
 
   /**
-   * "ILIKE" does't support
+   * "ILIKE" is not supported
    */
   public likeIgnoreCase(column, not, param, type) {
     const p = (!type || type === 'contains' || type === 'ends') ? '\'%\' || ' : '';
@@ -30,7 +30,7 @@ class OracleFilter extends BaseFilter {
 
 export class OracleQuery extends BaseQuery {
   /**
-   * "LIMIT" on Oracle it's illegal
+   * "LIMIT" on Oracle is illegal
    * TODO replace with limitOffsetClause override
    */
   public groupByDimensionLimit() {

packages/cubejs-schema-compiler/src/adapter/SnowflakeQuery.ts

@@ -53,10 +53,10 @@ export class SnowflakeQuery extends BaseQuery {
 
     return `DATEADD(${timeUnit},
         FLOOR(
-          DATEDIFF(${timeUnit}, ${this.timeStampCast(`'${origin}'`)}, ${source}) /
+          DATEDIFF(${timeUnit}, ${this.dateTimeCast(`'${origin}'`)}, ${source}) /
           DATEDIFF(${timeUnit}, ${beginOfTime}, (${beginOfTime} + interval '${intervalFormatted}'))
         ) * DATEDIFF(${timeUnit}, ${beginOfTime}, (${beginOfTime} + interval '${intervalFormatted}')),
-        ${this.timeStampCast(`'${origin}'`)})`;
+        ${this.dateTimeCast(`'${origin}'`)})`;
   }
 
   /**