Skip to content

Commit d934f61

Browse files
committed
feat(pinot-driver): Add enableNullHandling=true to query options
1 parent 5620f71 commit d934f61

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

docs/pages/product/configuration/data-sources/pinot.mdx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ workloads. [StarTree][link-startree] is a fully-managed platform for Pinot.
1414
- The hostname for the [Pinot][pinot] broker
1515
- The port for the [Pinot][pinot] broker
1616

17-
With the current implementation of the Pinot driver, you have to enable the
18-
[multi-stage query engine][link-pinot-msqe] in your Pinot cluster.
17+
Note that the following features should be enabled in your Pinot cluster:
18+
- [Multi-stage query engine][link-pinot-msqe].
19+
- [Advanced null value support][link-pinot-nvs].
1920

2021
## Setup
2122

@@ -97,6 +98,7 @@ Cube does not require any additional configuration to enable SSL as Pinot connec
9798
[link-pinot]: https://pinot.apache.org/
9899
[pinot]: https://docs.pinot.apache.org/
99100
[link-pinot-msqe]: https://docs.pinot.apache.org/reference/multi-stage-engine
101+
[link-pinot-nvs]: https://docs.pinot.apache.org/developers/advanced/null-value-support#advanced-null-handling-support
100102
[pinot-docs-approx-agg-fns]:
101103
https://docs.pinot.apache.org/users/user-guide-query/query-syntax/how-to-handle-unique-counting
102104
[ref-recipe-enable-ssl]:

packages/cubejs-pinot-driver/src/PinotDriver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export class PinotDriver extends BaseDriver implements DriverInterface {
167167
}),
168168
body: JSON.stringify({
169169
sql: query,
170-
queryOptions: `useMultistageEngine=true;timeoutMs=${this.config.queryTimeout}`
170+
queryOptions: `useMultistageEngine=true;enableNullHandling=true;timeoutMs=${this.config.queryTimeout}`
171171
})
172172
});
173173

0 commit comments

Comments
 (0)