Skip to content

Commit db422d0

Browse files
committed
remove perf logging
1 parent d3c2ab1 commit db422d0

File tree

2 files changed

+0
-33
lines changed

2 files changed

+0
-33
lines changed

packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.ts

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@ export class DataSchemaCompiler {
231231
|| f.fileName.endsWith('.yaml')
232232
|| f.fileName.endsWith('.jinja')).map(f => ({ ...f }));
233233

234-
const jinjaLoaderTimer = perfTracker.start('loadJinjaTemplates');
235-
236234
const jinjaTemplatedFiles = toCompile.filter((file) => file.fileName.endsWith('.jinja') ||
237235
(file.fileName.endsWith('.yml') || file.fileName.endsWith('.yaml')) && file.content.match(JINJA_SYNTAX));
238236

@@ -241,8 +239,6 @@ export class DataSchemaCompiler {
241239
this.loadJinjaTemplates(jinjaTemplatedFiles);
242240
}
243241

244-
jinjaLoaderTimer.end();
245-
246242
const errorsReport = new ErrorReporter(null, [], this.errorReportOptions);
247243
this.errorsReporter = errorsReport;
248244

@@ -570,8 +566,6 @@ export class DataSchemaCompiler {
570566
): Promise<(FileContent | undefined)> {
571567
try {
572568
if (getEnv('transpilationNative')) {
573-
const compileJsFileTimer = perfTracker.start('transpileJsFile (native)');
574-
575569
const reqData = {
576570
fileName: file.fileName,
577571
fileContent: file.content,
@@ -593,12 +587,8 @@ export class DataSchemaCompiler {
593587
errorsReport.addWarnings(res[0].warnings as unknown as SyntaxErrorInterface[]);
594588
errorsReport.exitFile();
595589

596-
compileJsFileTimer.end();
597-
598590
return { ...file, content: res[0].code };
599591
} else if (getEnv('transpilationWorkerThreads')) {
600-
const compileJsFileTimer = perfTracker.start('transpileJsFile (threads)');
601-
602592
const data = {
603593
fileName: file.fileName,
604594
content: file.content,
@@ -611,12 +601,8 @@ export class DataSchemaCompiler {
611601
errorsReport.addErrors(res.errors);
612602
errorsReport.addWarnings(res.warnings);
613603

614-
compileJsFileTimer.end();
615-
616604
return { ...file, content: res.content };
617605
} else {
618-
const compileJsFileTimer = perfTracker.start('transpileJsFile (inplace)');
619-
620606
const ast = parse(
621607
file.content,
622608
{
@@ -634,8 +620,6 @@ export class DataSchemaCompiler {
634620

635621
const content = babelGenerator(ast, {}, file.content).code;
636622

637-
compileJsFileTimer.end();
638-
639623
return { ...file, content };
640624
}
641625
} catch (e: any) {
@@ -669,8 +653,6 @@ export class DataSchemaCompiler {
669653
}
670654

671655
if (getEnv('transpilationNative')) {
672-
const transpileYamlFileTimer = perfTracker.start('transpileYamlFile (native)');
673-
674656
const reqData = {
675657
fileName: file.fileName,
676658
fileContent: file.content,
@@ -689,12 +671,8 @@ export class DataSchemaCompiler {
689671

690672
this.compiledYamlCache.set(cacheKey, res[0].code);
691673

692-
transpileYamlFileTimer.end();
693-
694674
return { ...file };
695675
} else if (getEnv('transpilationWorkerThreads')) {
696-
const transpileYamlFileTimer = perfTracker.start('transpileYamlFile (threads)');
697-
698676
const data = {
699677
fileName: file.fileName,
700678
content: file.content,
@@ -712,12 +690,8 @@ export class DataSchemaCompiler {
712690

713691
this.compiledYamlCache.set(cacheKey, res.content);
714692

715-
transpileYamlFileTimer.end();
716-
717693
return { ...file };
718694
} else {
719-
const transpileYamlFileTimer = perfTracker.start('transpileYamlFile (inplace)');
720-
721695
const transpiledFile = this.yamlCompiler.transpileYamlFile(file, errorsReport);
722696

723697
if (transpiledFile) {
@@ -727,8 +701,6 @@ export class DataSchemaCompiler {
727701

728702
this.compiledYamlCache.set(cacheKey, transpiledFile?.content || '');
729703

730-
transpileYamlFileTimer.end();
731-
732704
return transpiledFile;
733705
}
734706
}
@@ -738,8 +710,6 @@ export class DataSchemaCompiler {
738710
errorsReport: ErrorReporter,
739711
options: TranspileOptions
740712
): Promise<(FileContent | undefined)> {
741-
const transpileJinjaFileTimer = perfTracker.start('transpileJinjaFile (common)');
742-
743713
const renderedFile = await this.yamlCompiler.renderTemplate(
744714
file,
745715
this.standalone ? {} : this.cloneCompileContextWithGetterAlias(this.compileContext),
@@ -752,8 +722,6 @@ export class DataSchemaCompiler {
752722
// avoiding costly YAML/Python parsing again.
753723
file.content = renderedFile.content;
754724

755-
transpileJinjaFileTimer.end();
756-
757725
return this.transpileYamlFile(file, errorsReport, options);
758726
}
759727

packages/cubejs-schema-compiler/src/compiler/YamlCompiler.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import { nonStringFields } from './CubeValidator';
1919
import { ErrorReporter } from './ErrorReporter';
2020
import { camelizeCube } from './utils';
2121
import { CompileContext } from './DataSchemaCompiler';
22-
import { perfTracker } from './PerfTracker';
2322

2423
type EscapeStateStack = {
2524
inFormattedStr?: boolean;

0 commit comments

Comments
 (0)