[WIP add tests] fix(schema-compiler): Use segments as-is in rollupPreAggregation

This is to support member expression segments, as BaseFilter does not expect member expressions in it, i.e. in `filterToWhere` is always call `dimensionSql`

Author: mcheshkov

packages/cubejs-schema-compiler/src/adapter/MssqlQuery.ts

@@ -4,6 +4,7 @@ import moment from 'moment-timezone';
 import { QueryAlias, parseSqlInterval } from '@cubejs-backend/shared';
 import { BaseQuery } from './BaseQuery';
 import { BaseFilter } from './BaseFilter';
+import { BaseSegment } from './BaseSegment';
 import { ParamAllocator } from './ParamAllocator';
 
 const abbrs = {
@@ -53,11 +54,33 @@ class MssqlFilter extends BaseFilter {
   }
 }
 
+class MssqlSegment extends BaseSegment {
+  public filterToWhere(): string {
+    const where = super.filterToWhere();
+
+    const context = this.query.safeEvaluateSymbolContext();
+    if (context.rollupQuery) {
+      // Segment itself will be rendered as reference for rollupQuery
+      // In MSSQL using just `WHERE (segment_column) AND (other_filter)` is incorrect, because
+      // `segment_column` is not of boolean type, but of `BIT` type
+      // Correct way to work with them is to use `WHERE segment_column = 1`
+      // This relies on `wrapSegmentForDimensionSelect` mapping segment to a `BIT` data type
+      return `${where} = 1`;
+    }
+
+    return where;
+  }
+}
+
 export class MssqlQuery extends BaseQuery {
   public newFilter(filter) {
     return new MssqlFilter(this, filter);
   }
 
+  public newSegment(segment): BaseSegment {
+    return new MssqlSegment(this, segment);
+  }
+
   public castToString(sql) {
     return `CAST(${sql} as VARCHAR)`;
   }

packages/cubejs-schema-compiler/src/adapter/PreAggregations.js

@@ -1256,11 +1256,8 @@ export class PreAggregations {
 
     const from = this.query.joinSql(toJoin);
 
-    const segmentFilters = this.query.segments.map(
-      s => this.query.newFilter({ dimension: s.segment, operator: 'equals', values: [true] })
-    );
     const replacedFilters =
-      filters || segmentFilters
+      filters || this.query.segments
         .concat(this.query.filters).concat(
           this.query.timeDimensions.map(dimension => dimension.dateRange && ({
             filterToWhere: () => this.query.timeRangeFilter(