rewrite byId in CubeDictionary to Map<string, Cube>

Author: KSDaemon

packages/cubejs-schema-compiler/src/compiler/CubeDictionary.ts

@@ -8,24 +8,28 @@ export interface Cube {
 }
 
 export class CubeDictionary implements TranspilerCubeResolver, CompilerInterface {
-  public byId: Record<string, Cube>;
+  private byId: Map<string, Cube>;
 
   public constructor() {
-    this.byId = {};
+    this.byId = new Map<string, Cube>();
   }
 
   public compile(cubes: Cube[], _errorReporter?: ErrorReporter): void {
-    this.byId = {};
+    this.byId = new Map<string, Cube>();
     for (const cube of cubes) {
-      this.byId[cube.name] = cube;
+      this.byId.set(cube.name, cube);
     }
   }
 
-  public resolveCube(name: string): boolean {
-    return !!this.byId[name];
+  public resolveCube(name: string): Cube | undefined {
+    return this.byId.get(name);
   }
 
   public free(): void {
-    this.byId = {};
+    this.byId = new Map<string, Cube>();
+  }
+
+  public cubeNames(): string[] {
+    return Array.from(this.byId.keys());
   }
 }

packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.ts

@@ -560,7 +560,7 @@ export class DataSchemaCompiler {
   }
 
   private prepareTranspileSymbols() {
-    const cubeNames: string[] = Object.keys(this.cubeDictionary.byId);
+    const cubeNames: string[] = this.cubeDictionary.cubeNames();
     // We need only cubes and all its member names for transpiling.
     // Cubes doesn't change during transpiling, but are changed during compilation phase,
     // so we can prepare them once for every phase.

packages/cubejs-schema-compiler/src/compiler/transpilers/transpiler.interface.ts

@@ -8,12 +8,12 @@ export interface TranspilerInterface {
 }
 
 export interface TranspilerSymbolResolver {
-  resolveSymbol(cubeName, name): any;
-  isCurrentCube(name): boolean;
+  resolveSymbol(cubeName: string | null | undefined, name: string): any;
+  isCurrentCube(name: string): boolean;
 }
 
 export interface TranspilerCubeResolver {
-  resolveCube(name): boolean;
+  resolveCube(name: string): any;
 }
 
 export type SymbolResolver = (name: string) => any;