some polishment

Author: KSDaemon

packages/cubejs-backend-shared/src/env.ts

@@ -1803,11 +1803,30 @@ const variables: Record<string, (...args: any) => any> = {
     dataSource
   }: {
     dataSource: string,
-  }) => (
-    process.env[
+  }) => {
+    const val = process.env[
       keyByDataSource('CUBEJS_DB_DUCKDB_S3_USE_CREDENTIAL_CHAIN', dataSource)
-    ]
-  ),
+    ];
+
+    if (val) {
+      if (val.toLocaleLowerCase() === 'true') {
+        return true;
+      } else if (val.toLowerCase() === 'false') {
+        return false;
+      } else {
+        throw new TypeError(
+          `The ${
+            keyByDataSource(
+              'CUBEJS_DB_DUCKDB_S3_USE_CREDENTIAL_CHAIN',
+              dataSource,
+            )
+          } must be either 'true' or 'false'.`
+        );
+      }
+    } else {
+      return false;
+    }
+  },
 
   /** ***************************************************************
    * Presto/Trino Driver                                                  *

packages/cubejs-duckdb-driver/src/DuckDBDriver.ts

@@ -164,8 +164,9 @@ export class DuckDBDriver extends BaseDriver implements DriverInterface {
         }
       }
     }
-    const useCredentialChain = getEnv('duckdbS3UseCredentialChain', this.config);
-    if (useCredentialChain === 'true' || useCredentialChain === true) {
+
+    const useCredentialChain = this.config.duckdbS3UseCredentialChain || getEnv('duckdbS3UseCredentialChain', this.config);
+    if (useCredentialChain) {
       try {
         await execAsync('CREATE SECRET (TYPE S3, PROVIDER \'CREDENTIAL_CHAIN\')');
       } catch (e) {

packages/cubejs-duckdb-driver/test/DuckDBDriver.test.ts

@@ -73,23 +73,4 @@ describe('DuckDBDriver', () => {
       { id: '3', created: '2020-03-03T03:03:03.333Z', created_date: '2020-03-03T00:00:00.000Z', price: '300' }
     ]);
   });
-
-  test('should execute CREATE SECRET when duckdbS3UseCredentialChain is set', async () => {
-    process.env.duckdbS3UseCredentialChain = 'true';
-
-    // Create a new driver instance to pick up the environment variable
-    const driverWithCredentialChain = new DuckDBDriver({});
-
-    // Mock the execAsync method to spy on it
-    const execAsyncSpy = jest.spyOn((driverWithCredentialChain as any), 'execAsync');
-
-    await driverWithCredentialChain.testConnection();
-
-    expect(execAsyncSpy).toHaveBeenCalledWith(`CREATE SECRET (TYPE S3, PROVIDER 'CREDENTIAL_CHAIN')`);
-
-    // Clean up
-    delete process.env.duckdbS3UseCredentialChain;
-    execAsyncSpy.mockRestore();
-    await driverWithCredentialChain.release();
-  });
 });