small update in getThreadsCount

KSDaemon · KSDaemon · commit e8d5b62fe219 · 2025-04-07T12:30:36.000+03:00
diff --git a/packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.js b/packages/cubejs-schema-compiler/src/compiler/DataSchemaCompiler.js
@@ -29,7 +29,8 @@ const getThreadsCount = () => {
 
   const cpuCount = os.cpus()?.length;
   if (cpuCount) {
-    return Math.max(1, cpuCount - 1);
+    // there's no practical boost above 5 threads even if you have more cores.
+    return Math.min(Math.max(1, cpuCount - 1), 5);
   }
 
   return 3; // Default (like the workerpool do)

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ const getThreadsCount = () => {`
`29`	`29`
`30`	`30`	`const cpuCount = os.cpus()?.length;`
`31`	`31`	`if (cpuCount) {`
`32`		`- return Math.max(1, cpuCount - 1);`
	`32`	`+ // there's no practical boost above 5 threads even if you have more cores.`
	`33`	`+ return Math.min(Math.max(1, cpuCount - 1), 5);`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`return 3; // Default (like the workerpool do)`