chore(cubesql): Add comment about async generate_sql_for_expr

mcheshkov · mcheshkov · commit efdd41372d35 · 2024-12-10T17:29:20.000+02:00
diff --git a/rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs b/rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs
@@ -1214,6 +1214,8 @@ impl CubeScanWrapperNode {
             .map_err(|e| DataFusionError::Internal(format!("Can't generate SQL for type: {}", e)))
     }
 
+    /// This function is async to be able to call to JS land,
+    /// in case some SQL generation could not be done through Jinja
     pub fn generate_sql_for_expr<'ctx>(
         plan: Arc<Self>,
         mut sql_query: SqlQuery,

Original file line number	Diff line number	Diff line change
`@@ -1214,6 +1214,8 @@ impl CubeScanWrapperNode {`
`1214`	`1214`	`.map_err(\|e\| DataFusionError::Internal(format!("Can't generate SQL for type: {}", e)))`
`1215`	`1215`	`}`
`1216`	`1216`
	`1217`	`+ /// This function is async to be able to call to JS land,`
	`1218`	`+ /// in case some SQL generation could not be done through Jinja`
`1217`	`1219`	`pub fn generate_sql_for_expr<'ctx>(`
`1218`	`1220`	`plan: Arc<Self>,`
`1219`	`1221`	`mut sql_query: SqlQuery,`