Skip to content

Commit f0a4c9a

Browse files
committed
fix(schema-compiler): Fix incorrect sql generation for view queries referencing measures from joined cubes
1 parent eb33d1a commit f0a4c9a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,13 +1521,13 @@ export class BaseQuery {
15211521
this.queryCache
15221522
);
15231523
if (m.expressionName && !collectedMeasures.length && !m.isMemberExpression) {
1524-
throw new UserError(`Subquery dimension ${m.expressionName} should reference at least one measure`);
1524+
throw new UserError(`Subquery measure ${m.expressionName} should reference at least one member`);
15251525
}
15261526
if (!collectedMeasures.length && m.isMemberExpression && m.query.allCubeNames.length > 1 && m.measureSql() === 'COUNT(*)') {
15271527
const cubeName = m.expressionCubeName ? `\`${m.expressionCubeName}\` ` : '';
15281528
throw new UserError(`The query contains \`COUNT(*)\` expression but cube/view ${cubeName}is missing \`count\` measure`);
15291529
}
1530-
return [m.measure, collectedMeasures];
1530+
return [typeof m.measure === 'string' ? m.measure : `${m.measure.cubeName}.${m.measure.name}`, collectedMeasures];
15311531
}));
15321532
}
15331533

0 commit comments

Comments
 (0)