fix errors and mark getProxySettings() as deprecated

Author: KSDaemon

packages/cubejs-api-gateway/src/jwk.ts

@@ -1,6 +1,11 @@
 /* eslint-disable no-restricted-syntax */
 import crypto from 'crypto';
-import { asyncMemoizeBackground, asyncRetry, BackgroundMemoizeOptions, getHttpAgentForProxySettings } from '@cubejs-backend/shared';
+import {
+  asyncMemoizeBackground,
+  asyncRetry,
+  BackgroundMemoizeOptions,
+  getHttpAgentForProxySettings
+} from '@cubejs-backend/shared';
 import fetch from 'node-fetch';
 import jwkToPem from 'jwk-to-pem';
 import { JWTOptions } from './interfaces';
@@ -51,7 +56,7 @@ export type JWKsFetcherOptions = Pick<BackgroundMemoizeOptions<any, any>, 'onBac
 
 export const createJWKsFetcher = (jwtOptions: JWTOptions, options: JWKsFetcherOptions) => {
   const fetchJwkUrl = asyncMemoizeBackground(async (url: string) => {
-    const response = await asyncRetry(() => fetch(url, { agent: await getHttpAgentForProxySettings() }), {
+    const response = await asyncRetry(async () => fetch(url, { agent: await getHttpAgentForProxySettings() }), {
       times: jwtOptions.jwkRetry || 3,
     });
     const json = await response.json();

packages/cubejs-backend-shared/src/proxy.ts

@@ -14,7 +14,10 @@ function getCommandOutput(command: string) {
   });
 }
 
-// deprecated, use ProxyAgent instead
+/**
+ * @deprecated
+ * use ProxyAgent instead
+ */
 export async function getProxySettings() {
   const [proxy] = (
     await Promise.all([getCommandOutput('npm config -g get https-proxy'), getCommandOutput('npm config -g get proxy')])
@@ -26,5 +29,12 @@ export async function getProxySettings() {
 }
 
 export async function getHttpAgentForProxySettings() {
+  const proxy = await getProxySettings();
+
+  if (proxy) {
+    console.warn('Npm proxy settings are deprecated. Please use HTTP_PROXY, HTTPS_PROXY environment variables instead.');
+    return proxy;
+  }
+
   return new ProxyAgent();
 }