File tree Expand file tree Collapse file tree 4 files changed +6
-4
lines changed
packages/cubejs-backend-native/src Expand file tree Collapse file tree 4 files changed +6
-4
lines changed Original file line number Diff line number Diff line change 4545 run : cd packages/cubejs-backend-native && cargo fmt --all -- --check
4646 - name : Clippy Native
4747 run : cd packages/cubejs-backend-native && cargo clippy -- -D warnings
48+ - name : Clippy Native (with Python)
49+ run : cd packages/cubejs-backend-native && cargo clippy --features python -- -D warnings
4850 # CubeSQL is not ready for Clippy
4951 # - name: Clippy CubeSQL
5052 # run: cd rust/cubesql && cargo clippy -- -D warnings
Original file line number Diff line number Diff line change @@ -29,7 +29,7 @@ impl CLReprPython for CLRepr {
2929 return Ok ( Self :: Null ) ;
3030 }
3131
32- return Ok ( if v. get_type ( ) . is_subclass_of :: < PyString > ( ) ? {
32+ Ok ( if v. get_type ( ) . is_subclass_of :: < PyString > ( ) ? {
3333 let string_type = if v. hasattr ( "is_safe" ) ? {
3434 StringType :: Safe
3535 } else {
@@ -123,7 +123,7 @@ impl CLReprPython for CLRepr {
123123 }
124124
125125 Self :: PythonRef ( PythonRef :: PyObject ( v. into ( ) ) )
126- } ) ;
126+ } )
127127 }
128128
129129 fn into_py_impl ( from : CLRepr , py : Python ) -> Result < PyObject , PyErr > {
Original file line number Diff line number Diff line change @@ -34,7 +34,7 @@ pub fn cl_repr_py_function_wrapper(mut cx: FunctionContext) -> JsResult<JsPromis
3434 . this :: < JsValue > ( ) ?
3535 . downcast_or_throw :: < BoxedJsPyFunctionWrapper , _ > ( & mut cx) ?;
3636
37- let mut arguments = Vec :: with_capacity ( cx. len ( ) as usize ) ;
37+ let mut arguments = Vec :: with_capacity ( cx. len ( ) ) ;
3838
3939 for arg_idx in 0 ..cx. len ( ) {
4040 arguments. push ( CLRepr :: from_js_ref (
Original file line number Diff line number Diff line change @@ -66,7 +66,7 @@ impl CubeConfigPy {
6666 }
6767
6868 pub fn attr ( & mut self , config_module : & PyAny , key : & str ) -> PyResult < ( ) > {
69- let v = config_module. getattr ( & * key) ?;
69+ let v = config_module. getattr ( key) ?;
7070 if !v. is_none ( ) {
7171 let value = CLRepr :: from_python_ref ( v) ?;
7272 self . properties . insert ( key. to_case ( Case :: Camel ) , value) ;
You can’t perform that action at this time.
0 commit comments